Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49444/ --- (Updated July 6, 2016, 11:25 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49696: Used alias for the namespace 'process::http'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49696/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod

Re: Review Request 49529: Removed jsonFileInfo implementation from files.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49529/ --- (Updated July 6, 2016, 11:31 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/ --- (Updated July 6, 2016, 11:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

> On July 3, 2016, 1:52 a.m., haosdent huang wrote: > > src/files/files.cpp, lines 87-89 > > > > > > Why update these? Addressed, see Anand's comment on this review. - Abhishek

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49443/ --- (Updated July 6, 2016, 11:24 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49698: Renamed incorrect variable name in authorization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49698/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5757

Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5757

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review140974 --- Patch looks great! Reviews applied: [49688] Passed command:

Review Request 49699: Changed name of authorization test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49699/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5757

Review Request 49700: Added test to check orphaned tasks are filtered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49700/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5757

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/#review140980 --- Bad review! Reviews applied: [49689] Error: No reviewers

Re: Review Request 49308: Added agent and scheduler authentication backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/ --- (Updated July 6, 2016, 3:04 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49698: Renamed incorrect variable name in authorization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49698/#review140983 --- Ship it! Ship It! - haosdent huang On July 6, 2016, 11:28

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/#review140982 --- Ship it! Ship It! - haosdent huang On July 6, 2016, 11:27

Re: Review Request 49308: Added agent and scheduler authentication backoff.

> On July 5, 2016, 12:20 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 984-987 > > > > > > Does your solution address this trickiness after a master failover? AFAICT even the existing code exhibits that tricky

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/#review140995 --- Ship it! - Vinod Kone On July 6, 2016, 11:27 a.m., Joerg

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/ --- (Updated July 6, 2016, 4:52 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49651: Improved Mesos containerizer logging and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49651/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-5763

Review Request 49652: Improved Mesos containerizer invariant checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49652/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-5763

Review Request 49653: Made Mesos containerizer error messages more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49653/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-5763

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49650/#review141029 --- Fix it, then Ship it! Hmm...It surprises me the FETCHING state

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/ --- (Updated July 6, 2016, 6:06 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review140887 --- src/tests/hierarchical_allocator_tests.cpp (line 3629)

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- (Updated July 6, 2016, 11:37 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/ --- (Updated July 6, 2016, 7:16 p.m.) Review request for mesos. Repository:

Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/ --- (Updated July 6, 2016, 7:17 p.m.) Review request for mesos. Repository:

Re: Review Request 49279: Added documentation around available client libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49279/#review141063 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 7:07 p.m.,

Re: Review Request 49700: Added test to check orphaned tasks are filtered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49700/#review140999 --- src/tests/master_authorization_tests.cpp (lines 1938 - 1959)

Re: Review Request 49610: Added test case for quota allocation with reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49610/#review141008 --- Fix it, then Ship it! Thanks a lot for the test Neil! It looks

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/#review141022 --- src/master/http.cpp (line 2609)

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/ --- (Updated July 6, 2016, 4:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

> On July 6, 2016, 10:20 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1054 > > > > > > Please add a check on `DESTROYING` state, otherwise it may cost a race > > if destroy

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review141049 --- Fix it, then Ship it! src/master/http.cpp (line 1430)

Re: Review Request 49653: Made Mesos containerizer error messages more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49653/#review141059 --- src/slave/containerizer/mesos/containerizer.cpp (line 991)

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49686/ --- (Updated July 6, 2016, 6:08 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

> On July 6, 2016, 6:30 p.m., Vinod Kone wrote: > > i'll fix this while committing. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review141049

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/#review141047 --- Fix it, then Ship it! src/master/http.cpp (line 1557)

Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/ --- Review request for mesos. Repository: mesos Description --- WIP. This

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/ --- (Updated July 6, 2016, 6:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49651: Improved Mesos containerizer logging and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49651/#review141048 --- Fix it, then Ship it!

Re: Review Request 49652: Improved Mesos containerizer invariant checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49652/#review141053 --- src/slave/containerizer/mesos/containerizer.cpp (line 1058)

Re: Review Request 49710: Updated CHANGELOG with more accurate blurb about Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49710/#review141054 --- Fix it, then Ship it! Thanks! CHANGELOG (lines 106 - 110)

Re: Review Request 49690: Supported docker config agent flag with invalid value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49690/#review141043 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line

Re: Review Request 49308: Added agent and scheduler authentication backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review141041 --- Fix it, then Ship it! Looks great, except for the mismatch

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review141046 --- Ship it! Ship It! - Joerg Schad On July 6, 2016, 6:06 p.m.,

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49686/#review141051 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 6:08 p.m.,

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/#review141050 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 6:07 p.m.,

Re: Review Request 49279: Added documentation around available client libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49279/ --- (Updated July 6, 2016, 7:07 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49308: Added agent and scheduler authentication backoff.

> On July 6, 2016, 11:21 a.m., Adam B wrote: > > src/sched/sched.cpp, line 483 > > > > > > Seems `failedAuthentications` is never 0 here (since you increment it > > just before), so you'll never delay by the `[0, b

Re: Review Request 49696: Used alias for the namespace 'process::http'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49696/#review141068 --- Fix it, then Ship it! src/files/files.cpp (line 62)

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/#review141078 --- include/mesos/agent/agent.proto (lines 79 - 80)

Re: Review Request 49725: Fail container launch if it's destroyed during logger->prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49725/#review141083 --- Ship it! Ship It! - Jie Yu On July 6, 2016, 9:22 p.m.,

Re: Review Request 49652: Improved Mesos containerizer invariant checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49652/#review141084 --- Ship it! Ship It! - Jie Yu On July 6, 2016, 9:23 p.m.,

Review Request 49730: Added user doc for v1 master and agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49730/ --- Review request for mesos, Anand Mazumdar and Zhitao Li. Bugs: MESOS-4514

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

> On July 6, 2016, 10:47 a.m., Gilbert Song wrote: > > @yan: would you mind updating the unit test `DestroyWhileFetching` with > > another following patch? > > > > seems like it does not capture the race correctly. it seems insufficient to > > me after the containerizer.detroy() call. Will

Re: Review Request 49730: Added user doc for v1 master and agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49730/#review141088 --- Fix it, then Ship it! docs/operator-http-api.md (line 19)

Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/ --- (Updated July 6, 2016, 9:18 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49726: Fixed 'DestroyWhileFetching' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49726/#review141086 --- Ship it! Ship It! - Gilbert Song On July 6, 2016, 2:32

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49446/#review141069 --- Fix it, then Ship it! src/master/http.cpp (line 3143)

Re: Review Request 49694: Filter out fully used agents before allocate resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49694/#review141075 --- src/master/allocator/mesos/hierarchical.cpp (lines 1220 - 1228)

Re: Review Request 49653: Made Mesos containerizer error messages more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49653/ --- (Updated July 6, 2016, 2:24 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49650/ --- (Updated July 6, 2016, 2:20 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

> On July 6, 2016, 10:47 a.m., Gilbert Song wrote: > > @yan: would you mind updating the unit test `DestroyWhileFetching` with > > another following patch? > > > > seems like it does not capture the race correctly. it seems insufficient to > > me after the containerizer.detroy() call. > >

Re: Review Request 49694: Filter out fully used agents before allocate resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49694/#review141077 --- Patch looks great! Reviews applied: [49694] Passed command:

Re: Review Request 49652: Improved Mesos containerizer invariant checking.

> On July 6, 2016, 11:45 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1058 > > > > > > Should we check for DESTROYING here? It was put in a later review but now I have moved it

Re: Review Request 49725: Fail container launch if it's destroyed during logger->prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49725/#review141085 --- Ship it! Ship It! - Gilbert Song On July 6, 2016, 2:22

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review141079 --- include/mesos/agent/agent.proto (lines 149 - 152)

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review141066 --- Fix it, then Ship it! src/files/files.cpp (lines 356 - 358)

Re: Review Request 49598: Added ability to parse docker v1 'ImageManifest' from 'docker inspect'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49598/#review141073 --- Fix it, then Ship it! Looks good, just some minor comments

Re: Review Request 49725: Fail container launch if it's destroyed during logger->prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49725/ --- (Updated July 6, 2016, 2:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49696: Used alias for the namespace 'process::http'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49696/ --- (Updated July 6, 2016, 7:51 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review141070 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 785)

Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/ --- (Updated July 6, 2016, 9 p.m.) Review request for mesos. Changes ---

Re: Review Request 49652: Improved Mesos containerizer invariant checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49652/ --- (Updated July 6, 2016, 2:23 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 49653: Made Mesos containerizer error messages more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49653/ --- (Updated July 6, 2016, 2:23 p.m.) Review request for mesos, Jie Yu and Vinod

Review Request 49725: Fail container launch if it's destroyed during logger->prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49725/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 49651: Improved Mesos containerizer logging and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49651/ --- (Updated July 6, 2016, 2:22 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 49653: Made Mesos containerizer error messages more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49653/#review141081 --- Ship it! Ship It! - Jie Yu On July 6, 2016, 9:24 p.m.,

Review Request 49726: Fixed 'DestroyWhileFetching' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49726/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5763

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

> On July 6, 2016, 10:47 a.m., Gilbert Song wrote: > > @yan: would you mind updating the unit test `DestroyWhileFetching` with > > another following patch? > > > > seems like it does not capture the race correctly. it seems insufficient to > > me after the containerizer.detroy() call. > >

Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49722/#review141089 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 9:18 p.m.,

Re: Review Request 49699: Changed name of authorization test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49699/#review140997 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 11:29 a.m.,

Review Request 49707: Replaced raw string with const.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49707/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141011 --- CMakeLists.txt (lines 110 - 115)

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/ --- (Updated July 6, 2016, 4:18 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47292: Update docs to reflect contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review141023 --- Ship it! Ship It! - Kapil Arya On May 12, 2016, 7:19 a.m.,

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/ --- (Updated July 6, 2016, 5:21 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/ --- (Updated July 6, 2016, 5:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49650/#review141036 --- @yan: would you mind updating the unit test

Re: Review Request 49700: Added test to check orphaned tasks are filtered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49700/#review140998 --- Fix it, then Ship it!

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141000 --- Ship it! Ship It! - Guangya Liu On 七月 5, 2016, 9:48 p.m.,

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- (Updated July 6, 2016, 3:13 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49686/#review141021 --- src/master/http.cpp (line 3605)

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

> On July 6, 2016, 10:20 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1054 > > > > > > Please add a check on `DESTROYING` state, otherwise it may cost a race > > if destroy

Re: Review Request 49650: Fixed Mesos containerizer to set container FETCHING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49650/#review141034 --- Ship it! Ship It! - Jie Yu On July 6, 2016, 5:07 p.m.,

Re: Review Request 49690: Supported docker config agent flag with invalid value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49690/#review141010 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49697/#review141019 --- Ship it! Ship It! - Vinod Kone On July 6, 2016, 4:18 p.m.,

Review Request 49710: Updated CHANGELOG with more accurate blurb about Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49710/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

  1   2   >