----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review141079 -----------------------------------------------------------
include/mesos/agent/agent.proto (lines 149 - 152) <https://reviews.apache.org/r/49242/#comment206470> Similar comment to previous review. Kill this and include the comments explaining the fields inline in the protobuf. The reasoning is that, we are explaining the _business logic_ of the response and not the various arguments that were provided for the request. Those are _already_ explained in the request protobuf. ```cpp // Contains the file data. message ReadFile { // Comment optional string field1 = 1; } ``` or ```cpp // Contains the file data. message ReadFile { optional string field1 = 1; // Comment } ``` Pick any style based on the size of the comment. include/mesos/agent/agent.proto (line 152) <https://reviews.apache.org/r/49242/#comment206472> The 'length' field is part of the request. We need to mention about 'data' (part of response) - Anand Mazumdar On July 6, 2016, 5:19 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49242/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 5:19 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5515 > https://issues.apache.org/jira/browse/mesos-5515 > > > Repository: mesos > > > Description > ------- > > Add ReadFile message in the Response message of master.proto > , v1/master.proto, agent.proto, v1/agent.proto. > > > Diffs > ----- > > include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa > include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e > include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 > include/mesos/v1/master/master.proto > b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 > > Diff: https://reviews.apache.org/r/49242/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
