Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 18, 2017, 12:58 a.m.) Review request for mesos and Benjamin

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/#review162049 --- Fix it, then Ship it! support/jenkins/reviewbot.sh (line 30)

Re: Review Request 55657: Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/#review162055 --- Patch looks great! Reviews applied: [55657] Passed command:

Re: Review Request 55455: Moved `HealthChecker` into "checks" folder and namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55455/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55458: Added validation for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55458/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55453: Updated comments in `HealthCheck` protobuf for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55453/ --- (Updated Jan. 18, 2017, 9:30 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55459: Added task check validation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55457: Added protobufs for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55457/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55454: Ensured zero health check timeout means infinite timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55454/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55454: Ensured zero health check timeout means infinite timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55454/#review162056 --- Ship it! Ship It! - Vinod Kone On Jan. 18, 2017, 9:31 a.m.,

Re: Review Request 55453: Updated comments in `HealthCheck` protobuf for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55453/#review162053 --- include/mesos/mesos.proto (lines 424 - 426)

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 18, 2017, 1:02 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 18, 2017, 1:02 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.

> On Jan. 18, 2017, 5:30 a.m., Benjamin Mahler wrote: > > With respect to the comment, do you know when this check would fail? > > > > E.g. if an agent >= 0.24.0 registers the check holds > > > > Since by committing this I'm taking accountability of it being safe, it > > would be great if you

Re: Review Request 55455: Moved `HealthChecker` into "checks" folder and namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55455/#review162060 --- Ship it! Ship It! - Vinod Kone On Jan. 18, 2017, 10 a.m.,

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review162042 --- Patch looks great! Reviews applied: [55191] Passed command:

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 18, 2017, 1:04 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55455: Moved `HealthChecker` into "checks" folder and namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55455/ --- (Updated Jan. 18, 2017, 10 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55654/ --- (Updated Jan. 18, 2017, 12:58 a.m.) Review request for mesos and Benjamin

Review Request 55667: Added `libssl-dev` to `support/mesos-tidy/Dockerfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55667/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 55459: Added task check validation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review162073 --- src/tests/check_tests.cpp (line 31)

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

> On Jan. 18, 2017, 7:24 a.m., Greg Mann wrote: > > It seems like a bit of a shame that the standard agent recovery path > > involves two calls to `statusUpdateManager->resume`, which are likely to > > occur in quick succession. However, it seems like we expect frameworks to > > handle

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

> On Jan. 17, 2017, 7:11 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, line 171 > > > > > > I think we need a case insensitive os::getenv because one can use > > `HTTPS_PROXY` as well. > > > > Maybe

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/#review162061 --- src/launcher/executor.cpp (line 17)

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 18, 2017, 10:39 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55457: Added protobufs for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55457/#review162062 --- include/mesos/mesos.proto (lines 412 - 413)

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review162058 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 55611: Paused the status update manager in `Slave::initialize()`.

> On Jan. 18, 2017, 7:49 a.m., Greg Mann wrote: > > src/slave/slave.cpp, lines 557-560 > > > > > > Should we add a test that fails without this patch, i.e. one in which > > the agent drops a status update which is

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/#review162080 --- support/README.md (line 1)

Re: Review Request 55459: Added task check validation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review162086 --- Bad patch! Reviews applied: [55459, 55458, 55457, 55456, 55455,

Re: Review Request 55191: Add hostname support to the network/cni isolator.

> On Jan. 18, 2017, 11:02 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 288 > > > > > > I don't like the idea of piggybacking on this test. I'll probably > > create a new one. I

Re: Review Request 55458: Added validation for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55458/#review162067 --- src/checks/checker.hpp (line 31)

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55654/#review162071 --- Fix it, then Ship it! support/mesos-tidy/README.md (line 8)

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review162068 --- support/mesos-tidy.sh (line 22)

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

> On Jan. 17, 2017, 7:11 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, line 171 > > > > > > I think we need a case insensitive os::getenv because one can use > > `HTTPS_PROXY` as well. > > > > Maybe

Re: Review Request 55658: Updated Addition, modification and deletion of CNI configurations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55658/#review162076 --- Patch looks great! Reviews applied: [55658] Passed command:

Re: Review Request 55611: Paused the status update manager in `Slave::initialize()`.

> On Jan. 18, 2017, 7:49 a.m., Greg Mann wrote: > > src/slave/slave.cpp, lines 557-560 > > > > > > Should we add a test that fails without this patch, i.e. one in which > > the agent drops a status update which is

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 17, 2017, 10:10 a.m., Jay Guo wrote: > > Also, should we allow user to downgrade from a multi-role framework to > > single-role? I feel it would be very complicated and we should explicitly > > disallow that... > > Benjamin Bannier wrote: > I am not sure this is required. We

Re: Review Request 55686: Added custom target for 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/ --- (Updated Jan. 18, 2017, 10:25 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 55657: Added cpack to create source package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- (Updated Jan. 18, 2017, 10:25 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMakeCheck > > Alex Clemmer wrote:

Re: Review Request 55683: Rationalize process wait error checking.

> On Jan. 19, 2017, 12:43 a.m., Jiang Yan Xu wrote: > > src/launcher/fetcher.cpp, line 114 > > > > > > It's worth noting that > > > > ``` > > !WSUCCESS() > > ``` > > > > translates to > >

Re: Review Request 55683: Rationalize process wait error checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/ --- (Updated Jan. 19, 2017, 1:11 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55314: Windows: Added working Agent tests, moving pass rate ~75% -> ~87%.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55314/#review162198 --- Ship it! Ship It! - Joseph Wu On Jan. 7, 2017, 11:20 p.m.,

Re: Review Request 55691: Fix XSS vulnerability in pailer invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55691/#review162250 --- Patch looks great! Reviews applied: [55691] Passed command:

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Jan. 18, 2017, 11:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55686: Added custom target for 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/ --- (Updated Jan. 18, 2017, 10:22 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 55657: Added cpack to create source package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- (Updated Jan. 18, 2017, 10:23 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 55312: Windows: Added parent hooks to subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55312/#review162189 --- Ship it! `CREATE_JOB` code can use a few minor tweaks, which

Re: Review Request 55691: Fix XSS vulnerability in pailer invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55691/ --- (Updated Jan. 18, 2017, 11:37 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162210 --- Patch looks great! Reviews applied: [55676, 55677, 55678, 55679,

Review Request 55696: CMake: Separated Mesos system headers from Mesos API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55696/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55694: CMake: Separated Stout system headers from Stout API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55694/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55695: CMake: Separated Libprocess system headers from Libprocess API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55695/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55699: Stout: Added `host_default_path`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55699/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:06 a.m.) Review request for mesos, Andrew

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

> On Jan. 18, 2017, 1:50 a.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp, line 1055 > > > > > > It actually feels like `process::Winsock winsock;` is more appropriate > > here, as we want the socket

Review Request 55691: Fix XSS vulnerability in pailer invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55691/ --- Review request for mesos. Repository: mesos Description --- Fix XSS

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMakeCheck > > Alex Clemmer wrote:

Re: Review Request 55637: CMake: Added `test` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/ --- (Updated Jan. 18, 2017, 11:34 p.m.) Review request for mesos, Andrew

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review162226 --- Patch looks great! Reviews applied: [55381, 55571, 55271]

Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler,

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162234 --- Ship it! Ship It! - Benjamin Mahler On Jan. 19, 2017, 2:41

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162200 --- src/tests/command_executor_tests.cpp (lines 425 - 427)

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162202 --- Ship it! Ship It! - Joseph Wu On Jan. 18, 2017, 12:49 p.m.,

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

> On Jan. 18, 2017, 11:04 p.m., Joseph Wu wrote: > > src/tests/default_executor_tests.cpp, lines 442-444 > > > > > > Here too. Oh, shoot, sorry. I should have caught that. - Alex

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:13 a.m.) Review request for mesos, Andrew

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review162229 --- Fix it, then Ship it! The logic looks good to me, just a few

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:09 a.m.) Review request for mesos, Andrew

Re: Review Request 55328: Windows: Added passing GC tests to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55328/#review162204 --- Ship it! src/tests/gc_tests.cpp (lines 376 - 378)

Review Request 55689: Updated version in comment about TASK_LOST behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55689/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 55683: Rationalize process wait error checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/#review162196 --- Fix it, then Ship it! src/common/status_utils.hpp (line 26)

Re: Review Request 55686: Added custom target for 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/#review162238 --- Patch looks great! Reviews applied: [55657, 55686] Passed

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review162235 --- Fix it, then Ship it! This adjusts the code to fix the

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review162237 --- src/tests/hierarchical_allocator_tests.cpp (lines 2933 - 2936)

Re: Review Request 55689: Updated version in comment about TASK_LOST behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55689/#review162243 --- Patch looks great! Reviews applied: [55689] Passed command:

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- (Updated Jan. 18, 2017, 2:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55667: Added `libssl-dev` to `support/mesos-tidy/Dockerfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55667/#review162094 --- Ship it! Ship It! - Benjamin Bannier On Jan. 18, 2017, 9:57

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMakeCheck > > Alex Clemmer wrote:

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review162095 --- Ship it! Modulo my comments. - Benjamin Bannier On Jan. 18,

Re: Review Request 55496: Added support for HTTP responses with unspecified length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55496/ --- (Updated Jan. 18, 2017, 2:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote: > > support/README.md, lines 5-7 > > > > > > > The scripts directly in this directory are intended to be used by > > Mesos developers, while the build scripts in

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

> On Jan. 3, 2017, 10:25 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5507 > > > > > > can we inline this? > > Neil Conway wrote: > We could, but personally I find it more readable to make it a

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote: > > support/jenkins/buildbot.sh, line 22 > > > > > > Any reason this isn't named `MESOS_DIRECTORY` like similar variables in > > other places? See

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/#review162120 --- Patch looks great! Reviews applied: [55667, 55490, 55654, 55491]

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 18, 2017, 2:48 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 18, 2017, 3:36 a.m., Jay Guo wrote: > > src/master/master.hpp, lines 2522-2528 > > > > > > This check is only valid **iff** both `src` and `dest` frameworkInfo > > are single role, isn't it? maybe > >

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 18, 2017, 4:25 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

> On Jan. 18, 2017, 7:24 a.m., Greg Mann wrote: > > src/tests/slave_recovery_tests.cpp, line 1204 > > > > > > As long as you're cleaning this up, might as well fix the spacing - > > should be just one space before

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 18, 2017, 8:38 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55472/ --- (Updated Jan. 18, 2017, 5 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 18, 2017, 8:38 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

> On Jan. 18, 2017, 12:47 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1608-1617 > > > > > > The effect of this is to change `argv` from: > > > > ``` > >

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

> On Jan. 18, 2017, 1:06 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, line 1328 > > > > > > At the moment, I would not expect this to ever fail, > > `EXIT(EXIT_FAILURE)` is preferable. If it

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/ --- (Updated Jan. 18, 2017, 5:41 p.m.) Review request for mesos, Andrew

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

> On Jan. 18, 2017, 1:50 a.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp, line 1055 > > > > > > It actually feels like `process::Winsock winsock;` is more appropriate > > here, as we want the socket

Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/#review162141 --- Ship it! Ship It! - Benjamin Bannier On Jan. 18, 2017, 5:38

Re: Review Request 54573: Updated metrics counter during scheduler api calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54573/#review162142 --- Ship it! Ship It! - Zhitao Li On Jan. 17, 2017, 6:33 p.m.,

Re: Review Request 54572: Added metrics counter for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54572/#review162145 --- Ship it! can you also update the `docs/monitoring.md` file to

  1   2   >