Review Request 55710: Added Agent capabilities in the response of /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55710/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review162253 --- src/tests/master_validation_tests.cpp (lines 2774 - 2776)

Re: Review Request 55679: Unified the way in which the Slave API handlers perform AuthZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55679/ --- (Updated Jan. 19, 2017, 10:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55678/ --- (Updated Jan. 19, 2017, 10:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/#review162267 --- Ship it! Ship It! - Alexander Rojas On Jan. 19, 2017, 11:15

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/ --- (Updated Jan. 19, 2017, 10:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/ --- (Updated Jan. 19, 2017, 10:15 a.m.) Review request for mesos, Adam B,

Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/#review162266 --- src/slave/slave.cpp

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

> On Jan. 15, 2017, 10:55 a.m., Benjamin Bannier wrote: > > This is great. Could you make sure to follow up with setting > > `mesos/mesos-tidy` up for automated builds? Before building the image in > > the dockerhub time constraints was hard, but I am optimistic this would > > work now with

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 54214: Added unit test for aufs backend supporting many layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54214/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 6, 2017, 11:18 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 268 > > > > > > Given that the `layerPaths` are meant to be unique why not make the > >

Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/ --- Review request for mesos, Avinash sridharan, Jie Yu, Timothy Chen, and Jiang

Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54216/ --- (Updated Jan. 19, 2017, 4:07 a.m.) Review request for mesos, Avinash

Re: Review Request 54213: Supported more layers through symlink for aufs backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54213/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 54816: Replaced os::getcwd() to sandbox.get() in provisioner test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54816/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Review Request 55713: Added linux helper function fs::type() for filesystem id detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55713/ --- Review request for mesos, Avinash sridharan, Jie Yu, Timothy Chen, and Jiang

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162274 --- Ship it! Ship It! - Alexander Rojas On Jan. 19, 2017, 11:17

Re: Review Request 55683: Rationalize process wait error checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/#review162272 --- Patch looks great! Reviews applied: [55683] Passed command:

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54216/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 19, 2017, 2:01 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162279 --- Patch looks great! Reviews applied: [55701] Passed command:

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162283 --- Ship it! Looking through other instances of `spawn(.*,\

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162287 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 4256)

Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/#review162285 --- Ship it! Ship It! - Vinod Kone On Jan. 19, 2017, 10:15

Re: Review Request 55679: Unified the way in which the Slave API handlers perform AuthZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55679/#review162286 --- Ship it! Ship It! - Alexander Rojas On Jan. 19, 2017, 11:17

Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55678/#review162288 --- Ship it! Ship It! - Vinod Kone On Jan. 19, 2017, 10:17

Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55678/#review162282 --- Ship it! Ship It! - Alexander Rojas On Jan. 19, 2017, 11:17

Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/#review162291 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162293 --- Fix it, then Ship it! Modulo comments from Vinod.

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162292 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 3644)

Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55678/#review162294 --- Ship it! Ship It! - Anand Mazumdar On Jan. 19, 2017, 10:17

Re: Review Request 55679: Unified the way in which the Slave API handlers perform AuthZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55679/#review162296 --- Ship it! Ship It! - Anand Mazumdar On Jan. 19, 2017, 10:17

Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55472/#review162305 --- Ship it! Ship It! - Vinod Kone On Jan. 18, 2017, 5 p.m.,

Re: Review Request 55722: Removed redundant `Times(1)` statements from `api_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55722/#review162307 --- Ship it! Ship It! - Anand Mazumdar On Jan. 19, 2017, 4:18

Re: Review Request 55458: Added validation for a general check.

> On Jan. 18, 2017, 11:33 a.m., Vinod Kone wrote: > > src/checks/checker.hpp, line 31 > > > > > > This should be > > > > ``` > > Option validate(const CheckInfo& check); > > ``` I don't think so,

Re: Review Request 55458: Added validation for a general check.

> On Jan. 18, 2017, 11:33 a.m., Vinod Kone wrote: > > src/checks/checker.cpp, line 45 > > > > > > don't you want to validate that `check.command().has_command()` ? Probably not, this is a required field. -

Review Request 55732: Added `--3way` option to `git apply`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55732/ --- Review request for mesos, Jason Lai, Joseph Wu, and Michael Park. Bugs:

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review162351 --- Fix it, then Ship it! Thanks, looks good as far as validation

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/#review162354 --- src/linux/fs.hpp (line 152)

Review Request 55727: Checkpoint and track docker image layer sizes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55727/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs:

Re: Review Request 55691: Fix XSS vulnerability in pailer invocation.

> On Jan. 19, 2017, 4:27 p.m., haosdent huang wrote: > > Hi, seems set `document.cookie` could work instead of use localstorage. The > > problem of localstorage is not supported some old browsers. Have you try > > set cookie before? I think the attack vector would be similar if we were to

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/ --- (Updated Jan. 19, 2017, 3:33 p.m.) Review request for mesos, Avinash

Re: Review Request 55713: Added linux helper function fs::type() for filesystem id detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55713/ --- (Updated Jan. 19, 2017, 3:33 p.m.) Review request for mesos, Avinash

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

> On Jan. 19, 2017, 11:23 p.m., James Peach wrote: > > src/linux/fs.hpp, line 244 > > > > > > I get the analogy that leads to `magic`, but I'd prefer that it was > > named something more obvious. Maybe

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55727/#review162375 --- Patch looks great! Reviews applied: [53105, 53330, 55727]

Review Request 55740: Fixed unsafe usage of process pointer in loop.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55740/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Benjamin

Re: Review Request 55713: Added linux helper function fs::type() for filesystem id detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55713/#review162359 --- src/linux/fs.hpp (line 161)

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

> On Jan. 19, 2017, 6:08 a.m., Benjamin Bannier wrote: > > Looking through other instances of `spawn(.*,\ true)`, should this one also > > be adjusted, > > https://github.com/apache/mesos/blob/745b3c7589e5252cf93f62e081b78fa420771d0c/3rdparty/libprocess/include/process/loop.hpp#L134-L144?

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162361 --- Patch looks great! Reviews applied: [55676, 55722, 55677, 55678,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review162363 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Re: Review Request 55740: Fixed unsafe usage of process pointer in loop.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55740/#review162384 --- Ship it! I would suggest clarifying in the commit that there

Re: Review Request 55732: Added `--3way` option to `git apply`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55732/#review162383 --- Patch looks great! Reviews applied: [55732] Passed command:

Review Request 55745: Added scheduler adapter to API client libraries doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55745/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 55740: Fixed unsafe usage of process pointer in loop.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55740/#review162387 --- Patch looks great! Reviews applied: [55701, 55740] Passed

Re: Review Request 55710: Added Agent capabilities in the response of /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55710/ --- (Updated Jan. 20, 2017, 1:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review162327 --- Patch looks great! Reviews applied: [54216, 54212, 54213, 54214,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- (Updated Jan. 19, 2017, 10:45 a.m.) Review request for mesos, Avinash

Re: Review Request 55732: Added `--3way` option to `git apply`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55732/#review162389 --- support/apply-reviews.py (lines 120 - 121)

Review Request 55722: Removed redundant `Times(1)` statements from `api_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55722/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar,

Re: Review Request 55473: Marked a member function `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55473/#review162308 --- Fix it, then Ship it! src/master/master.cpp (lines 8758 -

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 19, 2017, 5:41 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 19, 2017, 4:37 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/ --- (Updated Jan. 19, 2017, 4:19 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55722: Removed redundant `Times(1)` statements from `api_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55722/#review162302 --- Ship it! Ship It! - Vinod Kone On Jan. 19, 2017, 4:18 p.m.,

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

> On Jan. 19, 2017, 2:23 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 4266 > > > > > > we don't do "Times(1)" since that is the default. > > > > just do > > > > ``` > >

Re: Review Request 55454: Ensured zero health check timeout means infinite timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55454/ --- (Updated Jan. 19, 2017, 5:39 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55453: Updated comments in `HealthCheck` protobuf for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55453/ --- (Updated Jan. 19, 2017, 5:39 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55458: Added validation for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55458/ --- (Updated Jan. 19, 2017, 5:46 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162297 --- Fix it, then Ship it! Modulo other comments from Vinod

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

> On Jan. 19, 2017, 3:20 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 3896 > > > > > > Maybe also verify parent container is still running. > > > > ``` > >

Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

> On Jan. 19, 2017, 4:48 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 8874-8876 > > > > > > does this not fit in one line? > > > > i know in the headers we sometimes put them on different lines

Re: Review Request 55455: Moved `HealthChecker` into "checks" folder and namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55455/ --- (Updated Jan. 19, 2017, 5:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55472/#review162306 --- src/master/master.cpp (lines 8871 - 8873)

Re: Review Request 55473: Marked a member function `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55473/ --- (Updated Jan. 19, 2017, 4:57 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55472/ --- (Updated Jan. 19, 2017, 4:57 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55691: Fix XSS vulnerability in pailer invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55691/#review162303 --- Hi, seems set `document.cookie` could work instead of use

Re: Review Request 55474: Renamed `taskTerminated` for Slave/Framework to `recoverResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55474/#review162310 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2017, 10:52

Re: Review Request 55457: Added protobufs for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55457/ --- (Updated Jan. 19, 2017, 5:42 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/#review162304 --- Ship it! Ship It! - Vinod Kone On Jan. 18, 2017, 7:18 p.m.,

Review Request 55748: CMake: Deleted spurious configuration settings in agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55748/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55749: Added CMake to standard documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55749/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55745: Added scheduler adapter to API client libraries doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55745/#review162390 --- Patch looks great! Reviews applied: [55745] Passed command: