Re: Review Request 58509: Enabled allocator to handle hierarchical reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58509/#review172760 --- After this change is introduced, I think we may need to update

Re: Review Request 58549: Updated agent webui page to display allocated and available resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58549/#review172826 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated April 24, 2017, 6:07 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On April 24, 2017, 5:48 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > > Lines 65 (patched) > > > > > > We started to move toward `enum class` now. Really? There are only 14

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57898/#review172814 --- Ship it! Is this ever going to be committed? I've been holding

Re: Review Request 58621: Add some parameter validation to RegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58621/#review172801 --- Ship it! Ship It! - Neil Conway On April 21, 2017, 4:57

Re: Review Request 58622: Document that master message validation is best effort.

> On April 24, 2017, 3:56 p.m., Neil Conway wrote: > > src/master/validation.hpp > > Lines 65 (patched) > > > > > > Can we link to a JIRA here? Did you have a specific JIRA in mind? I think MESOS-6903 is intended

Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58548/#review172827 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 58547: Fixed an inaccurately named table header in the agent webui page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58547/#review172828 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55896/ --- (Updated April 24, 2017, 6:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated April 24, 2017, 6:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58622: Document that master message validation is best effort.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58622/#review172797 --- Fix it, then Ship it! Can you also add a brief comment to the

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 24, 2017, 4:59 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review172813 --- Ship it! Ship It! - Jeff Coffler On April 14, 2017, 2:03

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On April 23, 2017, 10:48 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > > Lines 65 (patched) > > > > > > We started to move toward `enum class` now. > > James Peach wrote: >

Re: Review Request 58622: Document that master message validation is best effort.

> On April 24, 2017, 3:56 p.m., Neil Conway wrote: > > src/master/validation.hpp > > Lines 65 (patched) > > > > > > Can we link to a JIRA here? > > James Peach wrote: > Did you have a specific JIRA in mind? I

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172799 --- src/master/master.cpp Lines 5574 (patched)

Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/#review172812 --- Ship it! Ship It! - Jeff Coffler On April 14, 2017, 2:03

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/#review172809 --- Ship it! Ship It! - Jeff Coffler On April 19, 2017, 6:20

Re: Review Request 58661: Refactored test filter handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58661/#review172796 --- Ship it! Ship It! - Neil Conway On April 24, 2017, 11:20

Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58548/#review172829 --- src/webui/master/static/home.html Lines 136-139 (original),

Re: Review Request 58621: Add some parameter validation to RegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58621/ --- (Updated April 24, 2017, 5 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 58641: Fixed a style issue in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58641/#review172820 --- Ship it! Ship It! - Gilbert Song On April 21, 2017, 7:47

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

> On April 20, 2017, 9:40 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 298-302 (patched) > > > > > > Would it be possible to allow the user to exclude more than one at a > > time? I would also be

Re: Review Request 58557: Print failure reason when socket accept failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/#review172875 --- 3rdparty/libprocess/src/process.cpp Lines 950-951 (original),

Review Request 58690: Fixed leak of sensitive data in agent log of docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58690/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 58690: Fixed leak of sensitive data in agent log of docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58690/#review172881 --- Ship it! Ship It! - Adam B On April 24, 2017, 5:41 p.m.,

Re: Review Request 58557: Print failure reason when socket accept failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/ --- (Updated 四月 25, 2017, 1:14 a.m.) Review request for mesos, Jie Yu and Vinod

Review Request 58687: Made the activation of a client in `Sorter::add` explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58687/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.

Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.

Review Request 58688: Removed an incorrect CHECK in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58688/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.

Re: Review Request 58643: Added a TODO about an issue in POSIX disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58643/#review172878 --- Ship it! Ship It! - Gilbert Song On April 21, 2017, 7:47

Re: Review Request 58690: Fixed leak of sensitive data in agent log of docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58690/ --- (Updated April 25, 2017, 1:04 a.m.) Review request for mesos and Adam B.

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review172884 --- Patch looks great! Reviews applied: [55896, 55895, 55897, 55903]

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/ --- (Updated April 24, 2017, 8 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 58194: Hardened HTTP check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/ --- (Updated April 24, 2017, 10:12 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 58196: Implemented TCP check support in command and default executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/ --- (Updated April 24, 2017, 10:12 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 58509: Enabled allocator to handle hierarchical reservation.

> On April 24, 2017, 3:25 p.m., Qian Zhang wrote: > > After this change is introduced, I think we may need to update some docs, > > e.g., in > > https://github.com/apache/mesos/blob/master/docs/persistent-volume.md, it > > is mentioned that a persistent volume might be created by one

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 10:13 p.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 141 (patched) > > > > > > `s/role paths/client paths/`? > > Neil Conway wrote: > I said "role path"

Re: Review Request 58635: Updated the upgrade documentation for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58635/#review172852 --- Ship it! Ship It! - Vinod Kone On April 21, 2017, 10:02

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

> On April 20, 2017, 9:40 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 298-302 (patched) > > > > > > Would it be possible to allow the user to exclude more than one at a > > time? I would also be

Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.

> On April 24, 2017, 6:11 p.m., haosdent huang wrote: > > src/webui/master/static/home.html > > Lines 136-139 (original), 136-139 (patched) > > > > > > hi, @bamhler, do you think if we need to replace `used_` to >

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58421/#review172864 --- Ship it! Ship It! - Vinod Kone On April 18, 2017, 2 p.m.,

Re: Review Request 58506: Updated the high availability doc about ZK session timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58506/#review172865 --- Ship it! Ship It! - Vinod Kone On April 18, 2017, 2:23

Review Request 58683: Updated code and docs to use gender neutral pronoun.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58683/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Repository: mesos

Re: Review Request 58683: Updated code and docs to use gender neutral pronoun.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58683/#review172848 --- Ship it! Ship It! - Neil Conway On April 24, 2017, 7:46

Re: Review Request 58683: Updated code and docs to use gender neutral pronoun.

> On April 24, 2017, 7:52 p.m., Benjamin Mahler wrote: > > src/tests/zookeeper_test_server.cpp > > Line 130 (original), 130 (patched) > > > > > > This seems like a typo fix, mind committing it separately? Will do.

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/#review172853 --- Patch looks great! Reviews applied: [58603] Passed command:

Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/ --- (Updated April 24, 2017, 9:15 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58642: Cancelled the disk usage collection if no longer needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58642/#review172836 --- Ship it! Ship It! - Gilbert Song On April 21, 2017, 7:47

Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles.

> On April 20, 2017, 2:26 a.m., Jay Guo wrote: > > LGTM. I'm looking for MultioRole-related TODOs and see what could be > > resolved now. In the future, I feel labeling TODO seems to be a good > > practice worth calling out in the dev community. Yeah, we tried to do that with the "MULTI_ROLE"

Re: Review Request 58646: Fixed a style issue in v1 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58646/#review172835 --- Ship it! Ship It! - Gilbert Song On April 21, 2017, 7:49

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57516/#review172834 --- Ship it! Ship It! - Michael Park On April 20, 2017, 11:14

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated April 24, 2017, 6:53 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/#review172851 --- Ship it! Ship It! - Vinod Kone On April 21, 2017, 10:03

Review Request 58661: Refactored test filter handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58661/ --- Review request for mesos, Joseph Wu, Neil Conway, and Till Toenshoff.

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/ --- (Updated April 24, 2017, 1:22 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58348: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58348/ --- (Updated April 24, 2017, 1:23 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/ --- (Updated April 24, 2017, 1:23 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

> On April 11, 2017, 8:45 p.m., Neil Conway wrote: > > I'm curious what the goal of these assertions is: to fail the test (at > > runtime) if the current version of GTest is not thread-safe, right? It > > seems weird to be doing that at runtime, since whether GTest is threadsafe > > or not

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/ --- (Updated April 25, 2017, 5:40 a.m.) Review request for mesos, haosdent huang

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57516/#review172857 --- CHANGELOG Lines 16-17 (patched)

Re: Review Request 58683: Updated code and docs to use gender neutral pronoun.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58683/#review172841 --- Ship it! src/tests/zookeeper_test_server.cpp Line 130

Re: Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/#review172888 --- Bad review! Reviews applied: [58689, 58688, 58687, 57254, 58112,

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 21, 2017, 5:13 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 109 (patched) > > > > > > "sorter's tree"? Changed. > On April 21, 2017, 5:13 a.m., Michael Park

Re: Review Request 58644: Improved POSIX disk isolator to report usage for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58644/#review172891 --- src/slave/containerizer/mesos/isolators/posix/disk.cpp Lines

Re: Review Request 58584: Disabled support for setting quota on nested roles.

> On April 21, 2017, 6:01 a.m., Jay Guo wrote: > > src/master/quota_handler.cpp > > Lines 518-521 (patched) > > > > > > How about putting this before building `QuotaTree` so we don't bother > > to validate nested

Re: Review Request 58584: Disabled support for setting quota on nested roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58584/ --- (Updated April 24, 2017, 3:04 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 58348: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58348/#review172794 --- This RR does not seem to do what the RR's summary/description