Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62793/ --- (Updated Oct. 11, 2017, 9:28 a.m.) Review request for mesos, Alexander

Re: Review Request 62861: Updated list of excluded files by Python linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62861/#review187646 --- Patch looks great! Reviews applied: [62793, 62861] Passed

Re: Review Request 62643: Propagated the container termination to the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62643/#review187639 --- include/mesos/agent/agent.proto Lines 347 (patched)

Re: Review Request 62647: Printed resource limitations from mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62647/#review187654 --- Ship it! Ship It! - Qian Zhang On Sept. 28, 2017, 8:19

Re: Review Request 62644: Added resources to the TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62644/#review187650 --- include/mesos/mesos.proto Lines 2177 (patched)

Review Request 62887: Increased level for recurring master and agent verbose logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till

Re: Review Request 62648: Added a test for nested container resource limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62648/#review187655 --- Ship it! Ship It! - Qian Zhang On Oct. 10, 2017, 8:24 a.m.,

Re: Review Request 62861: Updated list of excluded files by Python linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62861/#review187645 --- PASS: Mesos patch 62861 was successfully built and tested.

Review Request 62886: Increased level for recurring allocator verbose logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till

Re: Review Request 62844: Bumped 'mesos-tidy' image to 'mesos_50'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62844/#review187696 --- Patch looks great! Reviews applied: [62844] Passed command:

Re: Review Request 62510: Fixed `LibeventSSLSocketImpl` for Windows file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62510/#review187706 --- Ship it! Ship It! - Joseph Wu On Oct. 2, 2017, 4:47 p.m.,

Re: Review Request 62887: Increased level of some verbose logs from master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187713 --- Patch looks great! Reviews applied: [62887] Passed command:

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review187711 --- src/launcher/default_executor.cpp Lines 489-490 (patched)

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Oct. 11, 2017, 11:18 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- (Updated Oct. 11, 2017, 11:32 p.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 11, 2017, 11:32 p.m.) Review request for mesos, Andrew

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review187703 --- include/mesos/resource_provider/resource_provider.proto Lines 55

Re: Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62913/#review187715 --- Ship it! Ship It! - Avinash sridharan On Oct. 11, 2017,

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrade guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/ --- (Updated Oct. 12, 2017, 12:10 a.m.) Review request for mesos and Alexander

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review187717 --- PASS: Mesos patch 62886 was successfully built and tested.

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Oct. 12, 2017, 12:11 a.m.) Review request for mesos, Andrei Budnik

Review Request 62912: Added tests for RWMutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/#review187714 --- docs/upgrades.md Line 318 (original), 359-360 (patched)

Review Request 62911: Added a RWMutex to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Oct. 11, 2017, 11:18 p.m.) Review request for mesos, Andrei Budnik

Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62913/ --- Review request for mesos, Avinash sridharan, Gaston Kleiman, and Vinod Kone.

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 11, 2017, 11:29 p.m.) Review request for mesos, Andrew

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Oct. 11, 2017, 11:30 p.m.) Review request for mesos, Andrew

Re: Review Request 62836: Ignored the tasks already being killed when killing the task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62836/#review187716 --- src/launcher/default_executor.cpp Line 894 (original), 903

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review187704 --- Ship it! Ship It! - Joseph Wu On Oct. 2, 2017, 4:45 p.m.,

Re: Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/#review187709 --- Ship it! Ship It! - Joseph Wu On Sept. 22, 2017, 12:52

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/ --- (Updated Oct. 11, 2017, 10:15 p.m.) Review request for mesos and Alexander

Re: Review Request 62844: Bumped 'mesos-tidy' image to 'mesos_50'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62844/#review187694 --- PASS: Mesos patch 62844 was successfully built and tested.

Re: Review Request 62876: Fix compile error for bundled gRPC on Debian 8 with libc-ares-dev.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62876/#review187695 --- Fix it, then Ship it! Can you remove trailing whitespace?

Re: Review Request 62740: Fixed using `FindOpenSSL` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62740/#review187705 --- Ship it! I can make the change below before committing. And

Re: Review Request 62511: Fixed OpenSSL support in libprocess for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62511/#review187707 --- Ship it! LGTM.

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/ --- (Updated Oct. 11, 2017, 10:10 p.m.) Review request for mesos and Alexander

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Oct. 11, 2017, 10:21 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62876: Fix compile error for bundled gRPC on Debian 8 with libc-ares-dev.

> On Oct. 11, 2017, 8:31 p.m., Zhitao Li wrote: > > 3rdparty/grpc-1.4.2.patch > > Lines 34 (patched) > > > > > > trailing whitespace? This is from the gRPC repo. I just cherry-picked the commits and use `git diff`

Re: Review Request 62891: Increased level of one verbose log from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review187710 --- PASS: Mesos patch 62891 was successfully built and tested.

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Oct. 11, 2017, 10:28 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62734: Added --markdown and --target-people to post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62734/#review187712 --- support/post-reviews.py Lines 142-144 (original), 142-146

Review Request 62844: Bumped 'mesos-tidy' image to 'mesos_50'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62844/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 62644: Added resources to the TaskStatus message.

> On Oct. 11, 2017, 12:48 p.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 7043-7044 (patched) > > > > > > These two lines can be merged into a single line. Yes but if you do that, the indentation of the

Re: Review Request 62898: Used variadic templates for protobuf handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62898/#review187724 --- Ship it! Ship It! - Benjamin Mahler On Oct. 11, 2017, 5:34

Review Request 62919: Added check to prevent in-source build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62919/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-7935

Re: Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/#review187727 --- FAIL: Failed to apply the dependent review: 62898. Failed

Re: Review Request 62900: Enabled protobuf arenas code generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62900/#review187726 --- Fix it, then Ship it! I assume you're only touching the files

Re: Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62913/#review187739 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/#review187738 --- FAIL: Mesos tests failed to build. Reviews applied: `['62502',

Re: Review Request 62912: Added tests for RWMutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/#review187734 --- PASS: Mesos patch 62912 was successfully built and tested.

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review187735 --- FAIL: Failed to apply the dependent review: 60292. Failed

Review Request 62891: Increased level for libprocess verbose logs regarding resumed processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till

Review Request 62893: Expand description of the --recovery_timeout flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62893/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 62897: Add MESOS-7941 to changelog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 62899: Added protobuf message passing benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6971

Review Request 62900: Enabled protobuf arenas code generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62900/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6971

Review Request 62898: Used variadic templates for protobuf handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62898/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6971

Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6971

Re: Review Request 62886: Increased level for recurring allocator verbose logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review187663 --- Let's also make the commit description a bit more like the next

Re: Review Request 62887: Increased level of some verbose logs from master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187666 --- PASS: Mesos patch 62887 was successfully built and tested.

Re: Review Request 62887: Increased level of some verbose logs from master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187667 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2017, 1:29

Review Request 62903: Added an `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 62732: Added CMake documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review187673 --- Ship it! Going to make some tweaks (rewording a couple

Re: Review Request 62733: Organized configuration documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/#review187683 --- Ship it! LGTM. - Joseph Wu On Oct. 5, 2017, 12:01 p.m.,

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62893/#review187679 --- PASS: Mesos patch 62893 was successfully built and tested.

Re: Review Request 62643: Propagated the container termination to the agent API.

> On Oct. 11, 2017, 12:18 p.m., Qian Zhang wrote: > > include/mesos/agent/agent.proto > > Lines 347 (patched) > > > > > > Can you elaborate a bit about why wrapping `repeated Resource resources > > = 4;` into a new

Re: Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62864/#review187672 --- Ship it! Ship It! - Vinod Kone On Oct. 10, 2017, 1:44 p.m.,

Re: Review Request 62864: Disabled Pylint error messages for apply-reviews support script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62864/#review187671 --- Ship it! Ship It! - Vinod Kone On Oct. 10, 2017, 1:44 p.m.,

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62893/#review187674 --- src/slave/flags.cpp Lines 454-457 (patched)