Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65570/#review197483 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1113-1132 (pat

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

> On Feb. 14, 2018, 12:12 a.m., Gilbert Song wrote: > > These comments are just for code refactoring. We could address them in a following patch. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197490 --- src/launcher/default_executor.cpp Line 791 (original), 794 (patch

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197497 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:41 a.m.,

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

> On Feb. 14, 2018, 4:08 a.m., Chun-Hung Hsiao wrote: > > I'll fix these while committing. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197475 -

Re: Review Request 65313: Refactored authorization logic in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/ --- (Updated Feb. 14, 2018, 11:51 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/#review197506 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 65616: Removed outdated executor-wide launched flag from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65616/#review197508 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:41 a.m.,

Re: Review Request 65552: Added a regression test for MESOS-8468.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/#review197509 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:24 a.m.,

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197510 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:13 a.m.,

Re: Review Request 65616: Removed outdated executor-wide launched flag from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65616/ --- (Updated Feb. 14, 2018, 8:48 p.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated Feb. 14, 2018, 3:21 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 26, 2018, 10:20 p.m., Vinod Kone wrote: > > src/slave/http.cpp > > Lines 1685 (patched) > > > > > > Not yours, but can we make the logging consistent here and in master > > for operator api handlers? Look

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65590/ --- (Updated Feb. 14, 2018, 4:11 p.m.) Review request for mesos, Jie Yu and Jan Sch

Review Request 65655: Used Mesos binaries instead of shell scripts to run CLI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65655/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-8240

Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197559 --- PASS: Mesos patch 64211 was successfully built and tested. Review

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197567 --- src/docker/executor.cpp Lines 304 (patched)

Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/#review197568 --- PASS: Mesos patch 65656 was successfully built and tested. Review

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

> On Feb. 13, 2018, 9:15 p.m., Andrei Budnik wrote: > > src/master/master.cpp > > Lines 2182-2185 (patched) > > > > > > Why do we need this case? What problem does it solve? It mainly ensures that the proposed fix

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197581 --- PASS: Mesos patch 64211 was successfully built and tested. Review

Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/#review197583 --- Patch looks great! Reviews applied: [65656] Passed command: expo

Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review197591 --- PASS: Mesos patch 65661 was successfully built and tested. Review

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 14, 2018, 5:49 p.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 304 (patched) > > > > > > This case means `docker stop` is in progress (`killed == true`): > > https://github.com/apache/meso

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197599 --- Patch looks great! Reviews applied: [65584, 65585, 65655, 64211]

Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/#review197609 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review197611 --- Patch looks great! Reviews applied: [65661] Passed command: expo