Re: Review Request 66289: Added fields to GET_STATE necessary for streaming Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66289/#review200014 --- Patch looks great! Reviews applied: [66289] Passed command:

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66219/#review200015 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 1320

Re: Review Request 66289: Added fields to GET_STATE necessary for streaming Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66289/#review28 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review200024 --- src/master/http.cpp Lines 1511-1513 (patched)

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review200012 --- include/mesos/master/master.proto Lines 187 (patched)

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review200018 --- include/mesos/master/master.proto Lines 187 (patched)

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/#review200011 --- Fix it, then Ship it! src/slave/slave.cpp Line 4173

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review200013 --- src/master/http.cpp Lines 1511-1513 (patched)

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199949 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66278: Ensured correct termination order in IOSwitchboard's main function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66278/#review199962 --- Ship it! Ship It! - Alexander Rukletsov On March 26, 2018,

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199954 --- Ship it! Thanks @gaston for the simplified

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199951 --- Patch looks great! Reviews applied: [66037] Passed command:

Review Request 66278: Ensured correct termination order in IOSwitchboard's main function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66278/ --- Review request for mesos, Alexander Rukletsov and Kevin Klues. Repository:

Re: Review Request 66233: Made the default executor log kill failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66233/#review199979 --- Ship it! Ship It! - Alexander Rukletsov On March 23, 2018,

Re: Review Request 66234: Fixed variable shadowing in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66234/#review199981 --- Ship it! Ship It! - Alexander Rukletsov On March 23, 2018,

Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65962/#review199980 --- Ship it! Ship It! - Alexander Rukletsov On March 21, 2018,

Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review199978 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 66248: Removed SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/#review199982 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/ --- (Updated March 26, 2018, 10:40 a.m.) Review request for mesos and Alexander

Review Request 66283: Added support of max_duration in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Re: Review Request 66248: Removed SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/#review199984 --- Patch looks great! Reviews applied: [66248] Passed command:

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated March 26, 2018, 9:54 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66248: Removed SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/#review199983 --- Ship it! Ship It! - Alexander Rukletsov On March 26, 2018,

Review Request 66284: Added test for max duration support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Re: Review Request 66234: Fixed variable shadowing in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66234/ --- (Updated March 26, 2018, 10:39 a.m.) Review request for mesos and Alexander

Re: Review Request 65693: Made the default executor fail kills if the response isn't "200 OK".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65693/ --- (Updated March 26, 2018, 10:38 a.m.) Review request for mesos, Alexander

Re: Review Request 65693: Made the default executor fail kills if the response isn't "200 OK".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65693/#review199974 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 65694: Made the default executor's handling of kill escalations more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/#review199976 --- Ship it! Ship It! - Alexander Rukletsov On March 23, 2018,

Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66232/#review199975 --- Ship it! Ship It! - Alexander Rukletsov On March 23, 2018,

Re: Review Request 65692: Changed the signature of a DefaultExecutor kill method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65692/#review199973 --- Ship it! Ship It! - Alexander Rukletsov On March 19, 2018,

Re: Review Request 66278: Ensured correct termination order in IOSwitchboard's main function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66278/#review199966 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/#review199669 --- This is missing a test for `operations_pending`. You could wait

Re: Review Request 66248: Removed SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/ --- (Updated March 26, 2018, 4:09 p.m.) Review request for mesos and Alexander

Re: Review Request 66284: Added test for max duration support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/#review199989 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review199986 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66293: Added test for default executor support of max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review22 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66291: Added support to max_duration in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Review Request 66292: Validated that all tasks in the same group have same max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66292/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review18 --- Patch looks great! Reviews applied: [65692, 65693, 66232, 65694,

Review Request 66293: Added test for default executor support of max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Re: Review Request 66293: Added test for default executor support of max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review24 --- Patch looks great! Reviews applied: [66258, 66259, 66260, 66283,

Review Request 66289: Added fields to GET_STATE necessary for streaming Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66289/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: