Re: Review Request 66481: Converted `pid` in command executor to `Option`.

2018-04-08 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200719 --- Fix it, then Ship it! src/launcher/executor.cpp Line 983 (orig

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review200720 --- Patch looks great! Reviews applied: [66481, 66258, 66259, 66260,