Re: Review Request 68276: Removed code using no longer existing endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68276/ --- (Updated Aug. 9, 2018, 9:45 a.m.) Review request for mesos and Alexander

Re: Review Request 68276: Removed code using no longer existing endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68276/#review207016 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 9, 2018,

Review Request 68276: Removed code using or testing no longer existing endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68276/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

> On Aug. 7, 2018, 4:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/utils.cpp > > Line 102 (original), 105 (patched) > > > > > > Are we guaranteed that there are no short-lived processes, other than >

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

> On Aug. 8, 2018, 1:19 a.m., Benjamin Mahler wrote: > > Just a high level comment, it's unfortunate that this test depends so much > > on timing w.r.t. to the 200ms polling interval. For example, if we actually > > serve the first request in less than 200ms then we wouldn't be measuring > >

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review207011 --- src/python/lib/mesos/http.py Lines 41 (patched)

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

> On Aug. 6, 2018, 11:40 a.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 628 (patched) > > > > > > The `async()` seems unnecessary here, we can just call the function > > directly. This is

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206879 --- Fix it, then Ship it! src/master/http.cpp Lines 2874

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/#review207023 --- Patch looks great! Reviews applied: [68266] Passed command:

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 7, 2018, 11:46 p.m., Benjamin Mahler wrote: > > Can we just have a single function instead of keeping the specialized > > TimeSeries overload? At some point we're going to have to do the copy > > elimination here so we'll probably take random access iterators and index > > directly

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review207037 --- Fix it, then Ship it!

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

> On Aug. 6, 2018, 5:57 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Line 80 (original), 80-82 (patched) > > > > > > Do you want a TODO to expose these in metrics snapshots?

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 9, 2018, 2:21 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 9, 2018, 2:15 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/ --- (Updated Aug. 9, 2018, 2:21 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Aug. 6, 2018, 11:40 a.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 496 (patched) > > > > > > Is it possible to store the last parameter directly as > > `process::Milliseconds`? Good

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 6, 2018, 10:59 a.m., Benno Evers wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Lines 60 (patched) > > > > > > Aren't you missing a `::value` after `std::is_same<>`, assuming you're > >

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Aug. 8, 2018, 1:19 a.m., Benjamin Mahler wrote: > > src/tests/master_benchmarks.cpp > > Lines 512 (patched) > > > > > > The review summary needs to updated to reflect the renaming? Good catch! - Alexander

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- (Updated Aug. 9, 2018, 2:20 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68054: Added networking statistics to cni isolator.

> On July 28, 2018, 12:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 1506-1507 (patched) > > > > > > No need for this temp variable > > Sergey Urbanovich wrote: >

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 10, 2018, 2:39 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review207052 --- Fix it, then Ship it! Please modify the agent.md

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207055 --- Patch looks great! Reviews applied: [68052, 68053, 68054]

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review207054 --- Ship it! Looks good, thank you Alex! This will be a big win

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review207045 --- Overall looks good, just a couple of minor comments below: