Re: Review Request 68564: Set up `-Wno-inconsistent-missing-override` conditionally.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68564/ --- (Updated Aug. 30, 2018, 9:11 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68579: Libprocess: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9193

Re: Review Request 68579: Libprocess: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/ --- (Updated Aug. 30, 2018, 9:17 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68582: Windows: Add `WclayerBackend` to provision Docker image.

2018-08-30 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68582/ --- Review request for mesos, Akash Gupta and Andrew Schwartzmeyer. Repository:

Review Request 68581: Windows: Port `wclayer` from `microsoft/hcsshim`.

2018-08-30 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68581/ --- Review request for mesos, Akash Gupta and Andrew Schwartzmeyer. Repository:

Review Request 68576: Mesos: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9193

[GitHub] tillt commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

2018-08-30 Thread GitBox
tillt commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native URL: https://github.com/apache/mesos/pull/285#issuecomment-417481608 @gouravrattihalli where did you get the "mesos-executor" egg from? In any case, I would advise you to

Review Request 68578: Stout: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9193

Review Request 68577: Stout: Fixed standalone build with libarchive.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68577/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, John Kordich, and

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-08-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 30, 2018, 8:47 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 30, 2018, 9:16 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68578: Stout: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/ --- (Updated Aug. 30, 2018, 9:17 p.m.) Review request for mesos, Benjamin Bannier

[GitHub] asfgit closed pull request #205: Clarify existence of FrameworkID in SUBSCRIBE calls.

2018-08-30 Thread GitBox
asfgit closed pull request #205: Clarify existence of FrameworkID in SUBSCRIBE calls. URL: https://github.com/apache/mesos/pull/205 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review208152 --- PASS: Mesos patch 68131 was successfully built and tested.

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208136 --- PASS: Mesos patch 68232 was successfully built and tested.

Re: Review Request 68555: Made checker library retry to remove the previous check container.

2018-08-30 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208144 --- Ship it! I would have probably added a `return` instead of an

Re: Review Request 68564: Disabled the `-Wunknown-warning-option` warnings for Clang 3.5.

2018-08-30 Thread James Peach
> On Aug. 30, 2018, 6:12 a.m., Benjamin Bannier wrote: > > configure.ac > > Lines 656 (patched) > > > > > > Instead of ignoring unknown warnings altogether we should check whether > > the current compiler supports

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/ --- (Updated Aug. 30, 2018, 3:46 p.m.) Review request for mesos, Alexander

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-30 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208145 --- Ship it! Ship It! - Gastón Kleiman On Aug. 24, 2018, 2:54

Re: Review Request 68068: Added tests for task metadata GC using the default executor.

2018-08-30 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68068/#review208157 --- Patch looks great! Reviews applied: [68065, 68066, 68067, 68095,

Re: Review Request 68582: Windows: Add `WclayerBackend` to provision Docker image.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68582/#review208155 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68578: Stout: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/ --- (Updated Aug. 31, 2018, 1:23 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 1:23 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68579: Libprocess: Used standard macros for appending compile flags.

2018-08-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/ --- (Updated Aug. 31, 2018, 1:24 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68564: Disabled the `-Wunknown-warning-option` warnings for Clang 3.5.

2018-08-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68564/#review208120 --- configure.ac Lines 656 (patched)

Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68565/#review208119 --- PASS: Mesos patch 68565 was successfully built and tested.

Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

2018-08-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68565/#review208121 --- Ship it! Ship It! - Benjamin Bannier On Aug. 30, 2018, 7:09

Re: Review Request 68566: Updated Python dependencies for Python 3.7.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68566/#review208122 --- PASS: Mesos patch 68566 was successfully built and tested.

Review Request 68566: Updated Python dependencies for Python 3.7.

2018-08-30 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68566/ --- Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.

Re: Review Request 68535: Simplified Python dependencies management.

2018-08-30 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/ --- (Updated Aug. 30, 2018, 10:07 a.m.) Review request for mesos, Benjamin

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208125 --- src/master/readonly_handler.cpp Lines 753 (patched)

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208129 --- PASS: Mesos patch 68568 was successfully built and tested.

Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-9194

Review Request 68567: Restructured /roles code.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68567/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Andrei Budnik
> On Aug. 29, 2018, 10:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 1710 (patched) > > > > > > Here we set the `promise` in the `readLoop`'s `onAny` callback, but > >

Re: Review Request 66114: Added supporting scripts for Mesos LLVM Tools.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66114/#review208131 --- support/llvm/install.sh Lines 24 (patched)

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Andrei Budnik
> On Aug. 30, 2018, 12:24 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Line 1704 (original), 1704 (patched) > > > > > > Does it have to be `Owned`? If yes and you need

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208127 --- src/slave/containerizer/mesos/io/switchboard.cpp Line 1704