Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for

Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/ --- (Updated Nov. 26, 2018, 8:30 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69402/ --- (Updated Nov. 26, 2018, 8:29 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69400: Refactored the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69400/ --- (Updated Nov. 26, 2018, 8:28 a.m.) Review request for mesos, Benjamin Bannier

Review Request 69450: Applied the `ContainerMountInfo` protobuf helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69450/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.

Re: Review Request 69086: Moved the container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Nov. 27, 2018, 12:49 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review210882 --- PASS: Mesos patch 69211 was successfully built and tested.

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210885 --- PASS: Mesos patch 69452 was successfully built and tested.

Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and

Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and

Review Request 69454: Added the autoconf `tar-pax` option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69454/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/ --- Review request for mesos. Repository: mesos Description --- Exposed the

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 26, 2018, 2:51 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210867 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/#review210863 --- src/python/cli_new/lib/cli/tests/base.py Lines 516 (patched)

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210866 --- Ship it! Ship It! - Kevin Klues On Nov. 26, 2018, 1:54

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review210858 --- src/tests/master_load_tests.cpp Lines 216 (patched)

Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/#review210862 --- Ship it! Ship It! - Kevin Klues On Nov. 22, 2018, 11:33

Re: Review Request 69420: Added Seccomp isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/#review210876 --- FAIL: Failed to apply the dependent review: 67844. Failed

Review Request 69449: Added the `DISCARD` blkio cgroup operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69449/ --- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.

Re: Review Request 69421: Exposed private data members for testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69421/#review210857 --- src/master/master.hpp Lines 1387 (patched)

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/#review210860 --- Ship it! Ship It! - Kevin Klues On Nov. 25, 2018, 9:53

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/ --- (Updated Nov. 26, 2018, 2:45 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 26, 2018, 2:54 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/#review210865 --- PASS: Mesos patch 69445 was successfully built and tested.

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210864 --- src/python/cli_new/lib/cli/tests/task.py Lines 250 (patched)

Re: Review Request 69447: Improved wording in comments for `AgentAdded` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69447/#review210873 --- PASS: Mesos patch 69447 was successfully built and tested.

Review Request 69447: Improved wording in comments for `AgentAdded` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69447/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 69441: Fixed sandbox creation chmod error handling in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69441/#review210872 --- Ship it! Ship It! - Ilya Pronin On Nov. 23, 2018, 9:22

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for

Re: Review Request 69449: Added the `DISCARD` blkio cgroup operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69449/#review210879 --- PASS: Mesos patch 69449 was successfully built and tested.

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Nov. 23, 2018, 5:44 a.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for