Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

> On Dec. 4, 2018, 6:36 a.m., Chun-Hung Hsiao wrote: > > src/tests/master_tests.cpp > > Lines 9276 (patched) > > > > > > Will we hit MESOS-6033 here? > > > > Also, will `disconnected` be called during

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

> On Dec. 4, 2018, 5:36 a.m., Chun-Hung Hsiao wrote: > > src/tests/master_tests.cpp > > Lines 9276 (patched) > > > > > > Will we hit MESOS-6033 here? > > > > Also, will `disconnected` be called during

Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.

> On Dec. 4, 2018, 7:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Line 189 (original), 189 (patched) > > > > > > This is a bit weird to me. I'd prefer just add a new

Re: Review Request 69210: Removed unnecesssarily verbose container mount logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69210/#review211022 --- Ship it! Ship It! - Jie Yu On Nov. 17, 2018, 12:49 a.m.,

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review211025 --- PASS: Mesos patch 69211 was successfully built and tested.

Re: Review Request 68138: Added tests to ensure correct quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68138/#review211024 --- Fix it, then Ship it!

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review211030 --- include/mesos/v1/mesos.proto Lines 2428 (patched)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211032 --- src/master/master.cpp Lines 12109 (patched)

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211033 --- PASS: Mesos patch 69505 was successfully built and tested.

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/#review211027 --- Fix it, then Ship it! include/mesos/executor/executor.proto

Re: Review Request 68795: Added deduplication for read-only master requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/#review211031 --- src/master/http.cpp Lines 2359-2362 (original), 2361-2364

Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9278

Re: Review Request 69472: Moved heartbeating helper out of master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/#review211028 --- src/common/heartbeater.hpp Lines 40 (patched)

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211029 --- src/slave/slave.cpp Lines 4679 (patched)

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review211034 --- Ship it! IMO you could get rid of the last bit in the commit