Review Request 69658: Avoided manual indexing during iteration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69658/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 69420: Added Seccomp isolator tests.

> On Dec. 29, 2018, 1:42 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_config.hpp > > Lines 17 (patched) > > > > > > I would suggest `__TEST_LINUX_SECCOMP_CONFIG_HPP__` as what we did in > > the

Re: Review Request 69600: Added tests for class `Quantity` and `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69600/#review211639 --- Stale summary? Partial review since it looks like some of what's

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211637 --- Ship it! LGTM. The button logic is similar to what is in

Re: Review Request 69601: Added a `Resources` method `contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69601/#review211638 --- include/mesos/resources.hpp Lines 45 (patched)

Re: Review Request 69603: Extended `min_allocatable_resources` flag to cover non-scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69603/#review211642 --- docs/configuration/master.md Line 210 (original), 210 (patched)

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 3, 2019, 1:58 a.m., Gilbert Song wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 147 (patched) > > > > > > Could we use `foreach (const ContainerSeccompProfile::Architecture& > > arch,

Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.

Review Request 69661: Added resource provider information to v0 agent state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69661/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8380

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Dec. 29, 2018, 1:40 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 89-92 (patched) > > > > > > This is kind of strange to me, I think we do not have this kind of

Re: Review Request 69409: Added Seccomp parser tests.

> On Dec. 28, 2018, 1:39 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_parser_tests.cpp > > Lines 92 (patched) > > > > > > We should check this field in the code below as well? Nope. Filtering by

Re: Review Request 68020: Added Seccomp-related flags to the agent.

> On Dec. 27, 2018, 7:47 a.m., Qian Zhang wrote: > > In the commit message of this patch, I would suggest to change `the path of > > the default Seccomp profile` to `the name of the default Seccomp profile`. Fixed. - Andrei --- This

Re: Review Request 68018: Added `SeccompFilter` class.

> On Dec. 13, 2018, 8:25 a.m., Gilbert Song wrote: > > src/linux/seccomp/seccomp.hpp > > Lines 27 (patched) > > > > > > Having the linux/seccomp common library to include containerizer.hpp > > seems a little strange

Re: Review Request 69597: Remove outstanding operations when removing agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/#review211661 --- Fix it, then Ship it! src/master/master.cpp Lines 11004

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211662 --- Fix it, then Ship it! src/tests/cluster.cpp Lines 691

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211658 --- Can you attach a screenshot of the web UI here? - Chun-Hung

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 2, 2019, 8:23 p.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > As we discussed last time, could we move this protobuf message to > >

Review Request 69665: Added missing 3rdparty patches to the distribution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69665/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9508

Re: Review Request 69665: Added missing 3rdparty patches to the distribution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69665/#review211663 --- Ship it! Ship It! - Jie Yu On Jan. 4, 2019, 12:57 a.m.,