> On Jan. 3, 2019, 1:58 a.m., Gilbert Song wrote:
> > src/linux/seccomp/seccomp.cpp
> > Lines 147 (patched)
> > <https://reviews.apache.org/r/68018/diff/11/?file=2116580#file2116580line147>
> >
> > Could we use `foreach (const ContainerSeccompProfile::Architecture&
> > arch, profile.architectures())`?
> >
> > So that it avoids the implicit conversion to `int` and also avoid the
> > `static_cast` below?
I've already replied to the same comment above from Qian.
The return type of `architectures()` is `const
::google::protobuf::RepeatedField<int>&`, so it won't compile:
`../../src/linux/seccomp/seccomp.cpp:147:85: error: invalid conversion from
‘int’ to ‘mesos::slave::ContainerSeccompProfile::Architecture {aka
mesos::slave::ContainerSeccompProfile_Architecture}’ [-fpermissive]`
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68018/#review211623
-----------------------------------------------------------
On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68018/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 3:24 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9034
> https://issues.apache.org/jira/browse/MESOS-9034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `SeccompFilter` class is a wrapper for `libseccomp` API. Its main
> purpose is to provide a translation of the `ContainerSeccompProfile`
> message into calls of `libseccomp` API.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8
> src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa
> src/linux/seccomp/seccomp.hpp PRE-CREATION
> src/linux/seccomp/seccomp.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68018/diff/12/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
