Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/#review212743 --- Fix it, then Ship it!

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

> On Feb. 12, 2019, 3:16 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 334 (patched) > > > > > > Could you briefly document what these do? > > > > We could

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

> On Feb. 12, 2019, 2 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3285-3291 (patched) > > > > > > I am wondering whether it would make sense to try to remove data from >

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

> On Feb. 12, 2019, 3:10 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 818 (original), 817 (patched) > > > > > > Is this needed? I believe so as there's no clock

Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69895/#review212739 --- Fix it, then Ship it!

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69904/#review212744 --- Fix it, then Ship it!

Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

> On Feb. 12, 2019, 2:21 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1984-1985 (patched) > > > > > > It looks like we use offers for synchronization here. Using a

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/#review212736 --- src/resource_provider/storage/provider.cpp Lines 797 (patched)

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/#review212740 --- src/tests/storage_local_resource_provider_tests.cpp Line 2282

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/#review212741 --- Ship it! Ship It! - Benjamin Bannier On Feb. 12, 2019, 6:22

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 12, 2019, 1:24 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 797 (patched) > > > > > > Since this is `defer`'ed, any chance this could race with > > `deleteVolume`

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/#review212738 --- Fix it, then Ship it!

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

> On Feb. 5, 2019, 6:55 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3244 (patched) > > > > > > Does this break seemless upgrades? Probably okay, but still something > >

Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69897/#review212742 --- Fix it, then Ship it!

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

> On Feb. 11, 2019, 6:58 p.m., Benjamin Mahler wrote: > > Nice patch, thanks Clément. Just a few minor comments below and we should > > be good to go. > > > > Just as an aside, the current hook interfaces are rather inefficient > > (copies the entire task info). If you're interested in

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 12, 2019, 1:24 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 945-950 (patched) > > > > > > Hmm, executing this only on the `!node_publish_required` path seems > >

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/#review212756 --- Ship it! Ship It! - Benjamin Mahler On Feb. 11, 2019, 10:27

Re: Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69905/#review212745 --- Fix it, then Ship it!

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Feb. 12, 2019, 8:41 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/ --- (Updated Feb. 12, 2019, 8:42 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69931: Empty test commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69931/#review212758 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 8:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69942: Added a test for MESOS-9554.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69942/#review212751 --- Fix it, then Ship it!

Re: Review Request 69942: Added a test for MESOS-9554.

> On Feb. 12, 2019, 6:34 p.m., Benjamin Bannier wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2924-2929 (patched) > > > > > > This test actually is more than a regression test for MESOS-9554 as it

Re: Review Request 69942: Added a test for MESOS-9554.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69942/#review212753 --- Ship it! Ship It! - Meng Zhu On Feb. 11, 2019, 10:21 a.m.,

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212759 --- src/master/allocator/mesos/hierarchical.cpp Lines 2072-2074

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212768 --- FAIL: Failed to get dependent review IDs for the current patch.

Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9535

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/ --- (Updated Feb. 12, 2019, 6:03 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Feb. 13, 2019, 3:08 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 69971: Removed an outdated comment in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69971/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 69893: Cleaned up persistent volumes on SLRP disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/ --- (Updated Feb. 13, 2019, 3:11 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69967: Added a recovery path for orphan operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69967/#review212786 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69970/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-9568

Re: Review Request 69969: Updated docs related to agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69969/#review212784 --- PASS: Mesos patch 69969 was successfully built and tested.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212785 --- Patch looks great! Reviews applied: [69900, 69902, 69818, 69862,

Re: Review Request 69969: Updated docs related to agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69969/ --- (Updated Feb. 13, 2019, 2:46 a.m.) Review request for mesos and Gastón

Re: Review Request 69971: Removed an outdated comment in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69971/#review212789 --- PASS: Mesos patch 69971 was successfully built and tested.

Review Request 69963: Handled terminal operation status updates for orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69963/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69968: Copied operation removal logic in agent removal code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69968/#review212783 --- PASS: Mesos patch 69968 was successfully built and tested.

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/#review212764 --- Ship it! Ship It! - Benjamin Bannier On Feb. 12, 2019, 9:42

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

> On Feb. 12, 2019, 2 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3285-3291 (patched) > > > > > > I am wondering whether it would make sense to try to remove data from >

Review Request 69958: Made an agent capability required for agent startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69958/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9535

Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9535

Review Request 69960: Added the concept of "orphaned operations" to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69960/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/ --- (Updated Feb. 12, 2019, 9:38 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/#review212772 --- src/master/master.cpp Lines 4372-4375 (original), 4373-4376

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/#review212777 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9558

Re: Review Request 69958: Made an agent capability required for agent startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69958/#review212778 --- Ship it! Ship It! - Gastón Kleiman On Feb. 12, 2019, 1:53

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/#review212779 --- src/tests/master_tests.cpp Lines 9753 (patched)

Review Request 69961: Handle possible orphaned operations after master/agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69961/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Review Request 69962: Added cleanup logic for orphaned operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69962/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

> On Feb. 13, 2019, 1:49 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9753 (patched) > > > > > > Can we check here that the framework doesn't get any operation status > > updates? Since

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/ --- (Updated Feb. 13, 2019, 2:39 a.m.) Review request for mesos and Gastón

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

> On Feb. 13, 2019, 12:08 a.m., Gastón Kleiman wrote: > > src/master/master.cpp > > Lines 4372-4375 (original), 4373-4376 (patched) > > > > > > The semantics of these capabilities is not very intuitive; we should

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/ --- (Updated Feb. 13, 2019, 2:37 a.m.) Review request for mesos and Gastón

Review Request 69968: Copied operation removal logic in agent removal code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69968/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69942: Added a test for MESOS-9554.

> On Feb. 12, 2019, 7:34 p.m., Benjamin Bannier wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2924-2929 (patched) > > > > > > This test actually is more than a regression test for MESOS-9554 as it

Re: Review Request 69880: Added header comments for two master methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69880/ --- (Updated Feb. 12, 2019, 9:38 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Re: Review Request 69958: Made an agent capability required for agent startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69958/ --- (Updated Feb. 12, 2019, 9:53 p.m.) Review request for mesos and Gastón

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/#review212776 --- PASS: Mesos patch 69964 was successfully built and tested.

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 9:42 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 9:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/#review212770 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 11:39 p.m.) Review request for mesos, Benjamin

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/ --- (Updated Feb. 12, 2019, 11:39 p.m.) Review request for mesos and Gastón

Review Request 69969: Updated docs related to agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69969/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9535

Review Request 69967: Added a recovery path for orphan operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69967/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/#review212735 --- Fix it, then Ship it!

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

> On fév. 11, 2019, 11:33 après-midi, Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['69938']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/#review212732 --- Patch looks great! Reviews applied: [69907, 69908, 69909]

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

> On Feb. 12, 2019, 12:33 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['69938']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/#review212734 --- Ship it! Ship It! - Benjamin Bannier On Feb. 6, 2019, 1:04