Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212791 --- PASS: Mesos patch 69972 was successfully built and tested.

Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9507

Re: Review Request 69969: Updated docs related to agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69969/#review212790 --- Patch looks great! Reviews applied: [69958, 69957, 69876, 69964,

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212795 --- Thanks for the patch! I think we should implement a test for

Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-9574

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 9:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 13, 2019, 11:31 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212820 --- Patch looks great! Reviews applied: [69900, 69902, 69818, 69862,

Review Request 69980: Modified when master responds to operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212811 --- PASS: Mesos patch 69890 was successfully built and tested.

Re: Review Request 69964: Added tests related to operation feedback agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69964/#review212813 --- Ship it! Ship It! - Gastón Kleiman On Feb. 12, 2019, 6:39

Re: Review Request 69969: Updated docs related to agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69969/#review212814 --- Ship it! Ship It! - Gastón Kleiman On Feb. 12, 2019, 6:46

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review212816 --- PASS: Mesos patch 69978 was successfully built and tested.

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review212817 --- Patch looks great! Reviews applied: [69977, 69978] Passed

Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69981/#review212819 --- PASS: Mesos patch 69981 was successfully built and tested.

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/ --- (Updated Feb. 14, 2019, 4:09 a.m.) Review request for mesos and Gastón

Re: Review Request 69862: Validated static framework offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69862/ --- (Updated Feb. 13, 2019, 11:31 p.m.) Review request for mesos, Benjamin Mahler

Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69981/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs:

Re: Review Request 69980: Modified when master responds to operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/#review212818 --- PASS: Mesos patch 69980 was successfully built and tested.

Review Request 69977: Improved agent operation recovery process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69977/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8054

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/ --- (Updated Feb. 13, 2019, 3:15 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69968: Copied operation removal logic in agent removal code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69968/ --- (Updated Feb. 13, 2019, 2:46 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69963: Handled terminal operation status updates for orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69963/ --- (Updated Feb. 13, 2019, 3:24 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

> On Jan. 14, 2019, 11:41 a.m., Joseph Wu wrote: > > src/tests/slave_recovery_tests.cpp > > Lines 5152-5153 (original), 5153-5154 (patched) > > > > > > Not terribly impactful for the test, but since you are

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212804 --- Ship it! Ship It! - Benjamin Mahler On Feb. 13, 2019, 3:44

Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69897/ --- (Updated Feb. 13, 2019, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212803 --- Patch looks great! Reviews applied: [69972] Passed command:

Re: Review Request 69968: Copied operation removal logic in agent removal code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69968/#review212806 --- Ship it! Ship It! - Greg Mann On Feb. 13, 2019, 2:05 a.m.,

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/ --- (Updated Feb. 13, 2019, 9:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

> On Feb. 12, 2019, 3:16 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 334 (patched) > > > > > > Could you briefly document what these do? > > > > We could

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69904/ --- (Updated Feb. 13, 2019, 9:26 p.m.) Review request for mesos and Benjamin

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/ --- (Updated Feb. 13, 2019, 9:20 p.m.) Review request for mesos and Benjamin

Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69895/ --- (Updated Feb. 13, 2019, 9:19 p.m.) Review request for mesos and Benjamin

Re: Review Request 69980: Modified when master responds to operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/#review212823 --- Patch looks great! Reviews applied: [69968, 69960, 69961, 69962,

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212822 --- src/slave/containerizer/mesos/launch.cpp Lines 556 (patched)

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 13, 2019, 4:44 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69971: Removed an outdated comment in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69971/#review212796 --- Patch looks great! Reviews applied: [69970, 69971] Passed