Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 300 (patched) > > > > > > Given that `state::checkpoint` is **atomic**, we can not

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > Thanks for the patch! > > I think we should implement a test for this. Otherwise, it would be very > > dangerous to _refactor_ this part of code in the future. > > If you have no chance to implement a test for this now, please feel free to

Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69994/#review212866 --- PASS: Mesos patch 69994 was successfully built and tested.

Re: Review Request 69986: Added a log line to isolator for simplified debugging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69986/ --- (Updated Feb. 15, 2019, 8:54 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 69986: Added a log line for simplified debugging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69986/#review212862 --- Ship it! Ship It! - Till Toenshoff On Feb. 14, 2019, 3:24

Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69994/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9507

Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69994/ --- (Updated Feb. 15, 2019, 5:08 p.m.) Review request for mesos, Andrei Budnik and

[GitHub] jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy.

jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy. URL: https://github.com/apache/mesos/pull/294#discussion_r257272993 ## File path: include/mesos/mesos.proto ## @@ -827,6 +827,18 @@ message ExecutorInfo { * in the same

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

> On Feb. 13, 2019, 1:28 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 300 (patched) > > > > > > Given that `state::checkpoint` is **atomic**, we can not

Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69994/#review212869 --- src/tests/containerizer/docker_volume_isolator_tests.cpp Lines

Re: Review Request 69907: Fixed variable names in `Master::_doRegistryGC()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69907/ --- (Updated Feb. 15, 2019, 6:02 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/ --- (Updated Feb. 15, 2019, 6:03 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/#review212877 --- PASS: Mesos patch 69909 was successfully built and tested.

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212878 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review212881 --- src/slave/slave.cpp Line 4711 (original), 4735 (patched)

Re: Review Request 69986: Added a log line to isolator for simplified debugging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69986/#review212882 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 69957: Updated master operation handling to account for new agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69957/#review212883 --- Ship it! Ship It! - Gastón Kleiman On Feb. 13, 2019, 8:09

Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.

> On Feb. 14, 2019, 9:12 a.m., Benjamin Mahler wrote: > > src/tests/master_quota_tests.cpp > > Lines 524-525 (patched) > > > > > > Hm.. we're actually waiting for the 200 OK, is this needed because the > > http

Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69994/#review212879 --- Patch looks great! Reviews applied: [69972, 69994] Passed

[GitHub] vinodkone merged pull request #294: FaultDomain, conventions for additional hierarchy.

vinodkone merged pull request #294: FaultDomain, conventions for additional hierarchy. URL: https://github.com/apache/mesos/pull/294 This is an automated message from the Apache Git Service. To respond to the message,