[GitHub] [mesos] bgalek opened a new pull request #341: Remove unnecessary logging.

bgalek opened a new pull request #341: Remove unnecessary logging. URL: https://github.com/apache/mesos/pull/341 There are metrics added in https://github.com/apache/mesos/commit/d93906a so this logging is not needed anymore.

Review Request 70989: Set the `MESOS_ALLOCATION_ROLE` environment variable for task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70989/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9874

[GitHub] [mesos] jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-507816894 Yes, I think this makes sense to include. On Tue, Jul 2, 2019 at 2:32 PM Vinod Kone wrote: > *@vinodkone* commented on this pull

Review Request 70996: Implemented master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70996/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

[GitHub] [mesos] jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-507790451 @vinodkone PTAL This is an automated message from the Apache Git Service. To respond

Review Request 70995: Fixed bugs in updating framework roles in the hierarchial allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70995/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9870

Review Request 70994: Moved to sepearte methods the (un)suppressing logic common with update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70994/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9870

Re: Review Request 70966: Test for removing a role from both roles and suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70966/ --- (Updated July 2, 2019, 7:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70900: Updated an equality operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70900/#review216324 --- Ship it! Ship It! - Joseph Wu On July 1, 2019, 12:52 p.m.,

Re: Review Request 70886: Override source address for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216315 --- Bad review! Reviews applied: [70886, 70933, 70797, 70992, 70991,

Re: Review Request 70980: Removed deactivation of already inactive roles on framework update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70980/#review216321 --- Bad review! Reviews applied: [70980, 70966, 70965, 70995, 70994]

Re: Review Request 70899: Refactored the agent's task-killing code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70899/#review216322 --- src/slave/slave.cpp Lines 3673-3680 (original), 3673-3679

Re: Review Request 70903: Killed all tasks on the agent when draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70903/#review216330 --- src/slave/slave.cpp Lines 1034 (patched)

Re: Review Request 70899: Refactored the agent's task-killing code.

> On June 27, 2019, 6:02 a.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 3755-3757 (original), 3787-3789 (patched) > > > > > > The `CHECK` for `TERMINATING` here does not fit the branch on > >

Re: Review Request 70989: Set the `MESOS_ALLOCATION_ROLE` environment variable for task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70989/#review216328 --- Ship it! Ship It! - Gilbert Song On July 2, 2019, 7:38

Re: Review Request 70886: Override source address for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216332 --- Bad review! Reviews applied: [70886, 70993, 70933, 70797, 70992,

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70985/#review216305 --- Bad review! Reviews applied: [70985, 70984, 70983, 70945, 70944,

Re: Review Request 70980: Removed deactivation of already inactive roles on framework update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70980/#review216306 --- Bad review! Reviews applied: [70980, 70966, 70965, 70979, 70978,

[GitHub] [mesos] bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340 This documents how to indicate when EOF is reached on STDIN. See

Review Request 70991: Updated `Socket::connect()` API according to maintainer feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/ --- Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.

Review Request 70992: Record Socket API change in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70992/ --- Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.

Review Request 70993: Added warnings about known problems with libevent epoll backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70993/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-9867

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/ --- (Updated July 2, 2019, 5:53 p.m.) Review request for mesos, Alexander

Re: Review Request 70748: Changed semantics of TLS certificate verification flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated July 2, 2019, 5:28 p.m.) Review request for mesos, Alexander

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70883/ --- (Updated July 2, 2019, 5:29 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70749: Introduced RFC6125-compliant hostname validation scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- (Updated July 2, 2019, 5:49 p.m.) Review request for mesos, Alexander

Re: Review Request 70748: Changed semantics of TLS certificate verification flags.

> On May 31, 2019, 3:05 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > > Lines 287-290 (patched) > > > > > > Can we also test that a client must *not* present a cert? I believe