Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217058 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 342

Re: Review Request 71192: Propagate ephemeral volume information from rootfs.

2019-08-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71192/#review217057 --- src/slave/containerizer/mesos/provisioner/backend.hpp Lines 55

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-02 Thread Jiang Yan Xu
> On Aug. 2, 2019, 4:03 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 424 (patched) > > > > > > FWIW sandbox scanning predates the container run state, now it does > >

Re: Review Request 71193: Supported multiple quota paths in the `disk/xfs` isolator.

2019-08-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71193/#review217059 --- Fix it, then Ship it!

Re: Review Request 71192: Propagate ephemeral volume information from rootfs.

2019-08-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71192/#review217060 --- Ship it! Ship It! - Jiang Yan Xu On July 31, 2019, 6:03

Review Request 71232: Renamed cmake parameter for parallel test execution.

2019-08-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71232/ --- Review request for mesos, Benno Evers and Till Toenshoff. Bugs: MESOS-6382

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/#review216947 --- I'm not sure if this is

Re: Review Request 71232: Renamed cmake parameter for parallel test execution.

2019-08-02 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71232/#review217050 --- Fix it, then Ship it! cmake/MesosConfigure.cmake Line 49

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217049 --- src/resource_provider/storage/provider.cpp Lines 749-768

Re: Review Request 71232: Renamed cmake parameter for parallel test execution.

2019-08-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71232/#review217051 --- Patch looks great! Reviews applied: [71232] Passed command: