Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71174/#review217375 --- Patch looks great! Reviews applied: [71174] Passed command:

Re: Review Request 71340: Allowed passing resource provider infos into call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71340/#review217377 --- Ship it! Ship It! - Jan Schlicht On Aug. 21, 2019, 3:22

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

> On Aug. 22, 2019, 2:38 p.m., Jan Schlicht wrote: > > src/resource_provider/validation.cpp > > Lines 17 (patched) > > > > > > Include this after `resource_provider/validation.hpp`. Ups, parsed this as another not

Re: Review Request 71339: Refactored resource provider call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71339/#review217378 --- Ship it! Ship It! - Jan Schlicht On Aug. 21, 2019, 3:22

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/ --- (Updated Aug. 22, 2019, 3:04 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71351/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9952

Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71350/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9952

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217376 --- Looks great, only have a few nits.

Review Request 71359: Optimized the allocation loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71359/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Review Request 71360: Optimized shrinkResources() by filtering before copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71360/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71345: Eliminated double lookups in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71345/#review217381 --- Ship it! Thanks for the cleanup! - Meng Zhu On Aug. 21,

Re: Review Request 71346: Avoid duplicate allocatableTo call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71346/#review217383 --- Ship it! Ship It! - Meng Zhu On Aug. 21, 2019, 5:28 p.m.,

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217382 --- Patch looks great! Reviews applied: [71339, 71340, 71341]

Re: Review Request 71315: Refactored master draining test setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/ --- (Updated Aug. 22, 2019, 11:31 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71316: Added draining tests for empty agents.

> On Aug. 21, 2019, 2:28 p.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 178 (patched) > > > > > > In this case, we probably want to either not set the max grace period, > > or set it to

Re: Review Request 71316: Added draining tests for empty agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- (Updated Aug. 22, 2019, 11:34 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71317: Added draining test for momentarily disconnected agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71317/ --- (Updated Aug. 22, 2019, 11:38 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71347: Optimized shrinkResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71347/#review217384 --- src/common/resources.cpp Line 1324 (original), 1298 (patched)

Re: Review Request 71353: Optimized Resources::shrink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71353/#review217387 --- Fix it, then Ship it! src/common/resources.cpp Line 1324

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/ --- (Updated Aug. 22, 2019, 4:58 p.m.) Review request for mesos and Benjamin

Review Request 71356: Updated the boost library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71356/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9806

Review Request 71357: Used boost `small_vector` in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71357/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9806

Review Request 71353: Optimized Resources::shrink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71353/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9806

Review Request 71354: Added ResourceQuantities::fromScalarResource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71354/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9806

Re: Review Request 71347: Optimized shrinkResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71347/ --- (Updated Aug. 22, 2019, 10:34 p.m.) Review request for mesos, Andrei

Re: Review Request 71354: Added ResourceQuantities::fromScalarResource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71354/#review217388 --- Ship it! Ship It! - Meng Zhu On Aug. 22, 2019, 3:34 p.m.,

Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71351/#review217389 --- Patch looks great! Reviews applied: [71350, 71351] Passed

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 22, 2019, 8:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 22, 2019, 8:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

> On Aug. 22, 2019, 2:27 a.m., James Peach wrote: > > src/slave/slave.cpp > > Line 7888 (original) > > > > > > Can you explain this more? > > > > In `Slave::applyOperation()`, there is a call to > >