Re: Review Request 71368: Updated site's middleman versions.

2019-08-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71368/#review217435 --- Ship it! Ship It! - Benjamin Mahler On Aug. 25, 2019, 9:20 a

Re: Review Request 71316: Added draining tests for empty agents.

2019-08-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/#review217436 --- Ship it! Ship It! - Greg Mann On Aug. 23, 2019, 7:22 p.m., J

Re: Review Request 71315: Refactored master draining test setup.

2019-08-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/#review217437 --- Ship it! Ship It! - Greg Mann On Aug. 22, 2019, 6:31 p.m., J

Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/ --- (Updated Aug. 26, 2019, 6:40 p.m.) Review request for mesos, Benno Evers and Ti

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217431 --- Ship it! bootstrap Lines 84 (patched)

Re: Review Request 71203: Added check script to check for license headers.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/#review217432 --- Ship it! support/check-license.py Lines 25-26 (patched)

Re: Review Request 71204: Added gitlint config.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/#review217433 --- Ship it! - Till Toenshoff On Aug. 14, 2019, 11:24 a.m., Benja

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217434 --- Ship it! Excellent structure - pretty much a move code only rev

Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217439 --- Fix it, then Ship it! When running the script, I noticed this `

Re: Review Request 71206: Removed old mesos-style and references.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/#review217444 --- Ship it! - Till Toenshoff On Aug. 20, 2019, 11:49 a.m., Benja

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/#review217441 --- Ship it! - Till Toenshoff On Aug. 20, 2019, 11:49 a.m., Benja

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217443 --- Ship it! I'ld love to see the commit description to tell us whi

Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217438 --- Ship it! - Till Toenshoff On Aug. 26, 2019, 4:40 p.m., Benjam

Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71208/#review217442 --- Ship it! - Till Toenshoff On July 30, 2019, 9:01 p.m., Benjam

Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217445 --- Bad patch! Reviews applied: [70096, 71203, 71204, 71299, 71205, 7