Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72754/ --- (Updated Aug. 18, 2020, 2:59 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221616 --- src/slave/slave.cpp Lines 1746-1749 (original), 1746-1751

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221618 --- Bad review! Reviews applied: [72779, 72728, 72761, 72727, 72726,

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221617 --- Bad review! Reviews applied: [72779, 72728, 72761, 72727, 72726,

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

> On Aug. 14, 2020, 6:21 a.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? > > Qian Zhang wrote: > Orginially I

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? > > Qian Zhang wrote: > Orginially I

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- (Updated Aug. 19, 2020, 12:22 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221621 --- Ship it! Ship It! - Greg Mann On Aug. 18, 2020, 4:22 p.m.,

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221630 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742,

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221624 --- Bad review! Reviews applied: [72787, 72786, 72785, 72784, 72783,

Re: Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72774/#review221627 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Line 729

Re: Review Request 72743: Wired up creating `OfferConstraintsFilter` into the schdeuler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72743/#review221629 --- Ship it! src/master/master.cpp Lines 2671 (patched)

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 43-56 (patched) > > > > > > We should check that they aren't both set? > > Andrei Sekretenko wrote: >

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? Changed to

Re: Review Request 72783: Added RE2 to the automake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72783/ --- (Updated Aug. 18, 2020, 7:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- (Updated Aug. 18, 2020, 6:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 72742: Added basic tests for the `OfferConstraintsFilter`.

> On Aug. 18, 2020, 6:36 p.m., Benjamin Mahler wrote: > > Great to have unit tests for this! Mainly left a suggestion about using a > > JSON approach to build the protobuf. > > > > Do we want to add another test here for attributes with multiple entries? > > (i.e. showing that we only look at

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ --- (Updated Aug. 18, 2020, 5:59 p.m.) Review request for mesos and Benjamin

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221628 --- Bad patch! Reviews applied: [72759] Failed command: ['bash',

Re: Review Request 72742: Added basic tests for the `OfferConstraintsFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221625 --- Great to have unit tests for this! Mainly left a suggestion about

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 18, 2020, 6:31 a.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 1746-1749 (original), 1746-1751 (patched) > > > > > > So do you want to implement `CSIServer::start()` in the way that I > >

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221632 --- src/slave/slave.cpp Lines 1747 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 18, 2020, 2:39 a.m., Qian Zhang wrote: > > src/slave/main.cpp > > Lines 583 (patched) > > > > > > I think it should be `--ip_discovery_command` or `--ip` flag, right? > > > >

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- (Updated Aug. 19, 2020, 10:52 a.m.) Review request for mesos, Andrei Budnik