DevinLeamy opened a new pull request, #528:
URL: https://github.com/apache/mesos/pull/528
Many cgroups tests require creating a child cgroup and then updating control
files within that cgroup. To avoid requiring test writers to manually cleanup
and conditionally create `TEST_CGROUP`, we
bmahler closed pull request #522: [cgroups2] Introduces the cpu namespace and
cpu::weight() API
URL: https://github.com/apache/mesos/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bmahler commented on code in PR #522:
URL: https://github.com/apache/mesos/pull/522#discussion_r1532377374
##
src/linux/cgroups2.cpp:
##
@@ -150,6 +150,18 @@ Try read(const string& cgroup, const string&
control)
}
+template <>
+Try read(const string& cgroup, const string&
bmahler commented on code in PR #528:
URL: https://github.com/apache/mesos/pull/528#discussion_r1532410807
##
src/tests/containerizer/cgroups2_tests.cpp:
##
@@ -33,7 +33,29 @@ namespace mesos {
namespace internal {
namespace tests {
-class Cgroups2Test : public
bmahler closed pull request #528: [cgroups2] Test fixture to cleanup
`TEST_CGROUP`.
URL: https://github.com/apache/mesos/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DevinLeamy commented on code in PR #519:
URL: https://github.com/apache/mesos/pull/519#discussion_r1532734374
##
src/linux/cgroups2.cpp:
##
@@ -295,4 +296,152 @@ Try> enabled(const string& cgroup)
} // namespace controllers {
+namespace devices {
+
+const int ALLOW_ACCESS
DevinLeamy commented on code in PR #519:
URL: https://github.com/apache/mesos/pull/519#discussion_r1532660172
##
src/linux/cgroups2.cpp:
##
@@ -295,4 +296,152 @@ Try> enabled(const string& cgroup)
} // namespace controllers {
+namespace devices {
+
+const int ALLOW_ACCESS
bmahler commented on code in PR #519:
URL: https://github.com/apache/mesos/pull/519#discussion_r1532862960
##
src/linux/cgroups2.hpp:
##
@@ -75,6 +77,10 @@ Try move_process(const std::string& cgroup, pid_t
pid);
// /sys/fs/cgroup. E.g. For /sys/fs/cgroup/test, this will