Re: [PR] [cgroups2] Implement Cgroups 2 isolator w/o nested containers and systemd. [mesos]

2024-04-19 Thread via GitHub
DevinLeamy commented on code in PR #556: URL: https://github.com/apache/mesos/pull/556#discussion_r1572831258 ## src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp: ## @@ -120,6 +144,569 @@ bool Cgroups2IsolatorProcess::supportsStandalone() return true; } +

[PR] [cgroups2] Error if `--cgroups_limit_swap` is used when cgroups v2 is used. [mesos]

2024-04-19 Thread via GitHub
DevinLeamy opened a new pull request, #565: URL: https://github.com/apache/mesos/pull/565 Mesos does not support limiting swap memory when using cgroups v2. This is because the cgroups v2 API does not allow us to directly control the swap memory usage limit. Rather, we can only control

Re: [PR] [cgroups2] Introduces an interface to read a subset of the memory usage statistics. [mesos]

2024-04-19 Thread via GitHub
bmahler closed pull request #564: [cgroups2] Introduces an interface to read a subset of the memory usage statistics. URL: https://github.com/apache/mesos/pull/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [cgroups2] Error if `--cgroups_limit_swap` is used when cgroups v2 is used. [mesos]

2024-04-19 Thread via GitHub
bmahler closed pull request #565: [cgroups2] Error if `--cgroups_limit_swap` is used when cgroups v2 is used. URL: https://github.com/apache/mesos/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [cgroups2] Introduces an interface to read a subset of the memory usage statistics. [mesos]

2024-04-19 Thread via GitHub
bmahler commented on code in PR #564: URL: https://github.com/apache/mesos/pull/564#discussion_r1573045523 ## src/linux/cgroups2.hpp: ## @@ -243,6 +243,41 @@ Try max(const std::string& cgroup); // See: https://docs.kernel.org/admin-guide/cgroup-v2.html namespace memory {

Re: [PR] [cgroups2] Error if `--cgroups_limit_swap` is used when cgroups v2 is used. [mesos]

2024-04-19 Thread via GitHub
bmahler commented on code in PR #565: URL: https://github.com/apache/mesos/pull/565#discussion_r1573038742 ## src/slave/flags.cpp: ## @@ -652,8 +657,25 @@ mesos::internal::slave::Flags::Flags() add(::cgroups_limit_swap, "cgroups_limit_swap", "Cgroups feature

[PR] [cgroups2] Introduces an interface to read a subset of the memory usage statistics. [mesos]

2024-04-19 Thread via GitHub
DevinLeamy opened a new pull request, #564: URL: https://github.com/apache/mesos/pull/564 Cgroups v2 exposes memory statistics through the 'memory.stat' control. Here we introduce `cgroups2::memory::stats` to read a subset of the memory usage statistics into a new `memory::Stats`

Re: [PR] [cgroups2] Error if `--cgroups_limit_swap` is used when cgroups v2 is used. [mesos]

2024-04-19 Thread via GitHub
bmahler commented on PR #565: URL: https://github.com/apache/mesos/pull/565#issuecomment-2067370799 > This is because the cgroups v2 API does not allow us to directly control the swap memory usage limit. Rather, we can only control the combined swap and RAM usage limit. This doesn't

Re: [PR] [cgroups2] Introduces API to make cgroups threaded and read their type. [mesos]

2024-04-19 Thread via GitHub
DevinLeamy commented on PR #562: URL: https://github.com/apache/mesos/pull/562#issuecomment-2066644211 Since we want the isolated ("containerized") process to be able to manipulate its own cgroups, if it so chooses, we're opting to no have the leaf cgroup for each container be threaded,

Re: [PR] [cgroups2] Introduces API to make cgroups threaded and read their type. [mesos]

2024-04-19 Thread via GitHub
DevinLeamy closed pull request #562: [cgroups2] Introduces API to make cgroups threaded and read their type. URL: https://github.com/apache/mesos/pull/562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to