Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-11 Thread Chen Nan Li
AG20-TECHS/ARIA11 2. Providing heading elements at the beginning of each section of content. So for the header section we need provide a h1 refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html Thanks, Chen Nan Li

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-15 Thread Chen Nan Li
5b1227e9d64757f9fc106e497f7fa3ed72112c10 Diff: https://reviews.apache.org/r/47055/diff/ Testing --- Ensuring that a contrast ratio of at least 4.5:1 exists between text (and images of text) and background behind the text. refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html Thanks, Chen Nan Li

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-15 Thread Chen Nan Li
, visit: https://reviews.apache.org/r/46954/#review133119 ----------- On 五月 6, 2016, 8:57 a.m., Chen Nan Li wrote: > > --- > This is an automatically gener

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-12 Thread Chen Nan Li
www.w3.org/TR/WCAG20-TECHS/ARIA11 2. Providing heading elements at the beginning of each section of content. So for the header section we need provide a h1 refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html Thanks, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-12 Thread Chen Nan Li
/H73.html Thanks, Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-11 Thread Chen Nan Li
-------- On 五月 8, 2016, 12:04 p.m., Chen Nan Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46965/ > --

Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-03 Thread Chen Nan Li
--- Have checked with the patch by firebug, the ID of each table header is different with each other. Thanks, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-04 Thread Chen Nan Li
.html Thanks, Chen Nan Li

Review Request 46966: Form controls must have associated labels.

2016-05-04 Thread Chen Nan Li
ble label can reduce the accessibility and usability of the control for a range of users including older users and users with cognitive, mobility. refer to https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/ Thanks, Chen Nan Li

Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-04 Thread Chen Nan Li
--- Mesos log page should have a title for details: https://www.w3.org/TR/WCAG20-TECHS/H25 And Should give a heading to tell screen reader that content in the page is Mesos log Thanks, Chen Nan Li

Review Request 46964: Using the summary attribute of the table element.

2016-05-04 Thread Chen Nan Li
/slaves.html 063031771cef8b9f45723869198bad3460591936 Diff: https://reviews.apache.org/r/46964/diff/ Testing --- Have checked with the patch by firebug, each table should have summary attribute. For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html Thanks, Chen Nan Li

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-04 Thread Chen Nan Li
: https://reviews.apache.org/r/46954/diff/ Testing (updated) --- Have checked with the patch by firebug, the ID of each table header is different with each other. can refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93 Thanks, Chen Nan Li

Re: Review Request 46966: Added associated labels to form in webui

2016-05-05 Thread Chen Nan Li
m/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/ Thanks, Chen Nan Li

Re: Review Request 46966: Form controls must have associated labels.

2016-05-05 Thread Chen Nan Li
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review131883 --- On 五月 5, 2016, 1:11 a.m., Chen Nan Li wrote: > > --- > This is an automatically ge

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
/ Testing --- We should use the scope attribute to associate header cells and data cells in data tables. It can make screen readers to find a header of date cell in table. for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html Thanks, Chen Nan Li

Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
to find a header of date cell in table. for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html Thanks, Chen Nan Li

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-05 Thread Chen Nan Li
.html Thanks, Chen Nan Li

Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-05 Thread Chen Nan Li
/ Testing --- Ensuring that a contrast ratio of at least 4.5:1 exists between text (and images of text) and background behind the text. refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html Thanks, Chen Nan Li

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-05 Thread Chen Nan Li
: https://reviews.apache.org/r/46954/diff/ Testing (updated) --- Have checked with the patch by firebug, the ID of each table header is different with each other. For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93 Thanks, Chen Nan Li

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
/ Testing --- We should use the scope attribute to associate header cells and data cells in data tables. It can make screen readers to find a header of date cell in table. for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html Thanks, Chen Nan Li

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-06 Thread Chen Nan Li
: https://reviews.apache.org/r/46954/diff/ Testing --- Have checked with the patch by firebug, the ID of each table header is different with each other. For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93 Thanks, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-06 Thread Chen Nan Li
/r/46964/diff/ Testing --- Have checked with the patch by firebug, each table should have summary attribute. For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html Thanks, Chen Nan Li

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-06 Thread Chen Nan Li
://reviews.apache.org/r/47055/diff/ Testing --- Ensuring that a contrast ratio of at least 4.5:1 exists between text (and images of text) and background behind the text. refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html Thanks, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-06 Thread Chen Nan Li
063031771cef8b9f45723869198bad3460591936 Diff: https://reviews.apache.org/r/46964/diff/ Testing --- Have checked with the patch by firebug, each table should have summary attribute. For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html Thanks, Chen Nan Li

Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-04 Thread Chen Nan Li
ing heading elements at the beginning of each section of content. So for the header section we need provide a h1 refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html Thanks, Chen Nan Li

Re: Review Request 46966: Added associated labels to form in webui

2016-05-08 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review132050 ----------- On 五月 6, 2016, 1:29 a.m., Chen Nan Li wrote: > > --- >

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-08 Thread Chen Nan Li
it: https://reviews.apache.org/r/47058/#review132055 --- On 五月 6, 2016, 8:57 a.m., Chen Nan Li wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-08 Thread Chen Nan Li
/reviews.apache.org/r/46964/#comment196341> ok thanks - Chen Nan Li On 五月 6, 2016, 8:56 a.m., Chen Nan Li wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-08 Thread Chen Nan Li
hanks hoasdent - Chen Nan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46965/#review132041 --- On May 5, 2016, 5

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-08 Thread Chen Nan Li
board` + a `main`. The other one is > > `main`. yes, should be the main, it's more reasonable. - Chen Nan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46965/#review132041 -

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-08 Thread Chen Nan Li
, haosdent huang wrote: > > src/webui/master/static/slave_framework.html, line 80 > > <https://reviews.apache.org/r/46964/diff/5/?file=1374543#file1374543line80> > > > > s/the current running/the running/g Thanks - Chen Nan -----------

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-08 Thread Chen Nan Li
esos log" Thanks, Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-08 Thread Chen Nan Li
AG20-TECHS/ARIA11 2. Providing heading elements at the beginning of each section of content. So for the header section we need provide a h1 refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html Thanks, Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-08 Thread Chen Nan Li
AG20-TECHS/ARIA11 2. Providing heading elements at the beginning of each section of content. So for the header section we need provide a h1 refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html Thanks, Chen Nan Li

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-08 Thread Chen Nan Li
. for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html Thanks, Chen Nan Li

Re: Review Request 46966: Form controls must have associated labels.

2016-05-08 Thread Chen Nan Li
e, mobility. refer to https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/ Thanks, Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-08 Thread Chen Nan Li
tps://reviews.apache.org/r/46964/#comment196346> I think the tables in left dashboard do not have complex structure. so no need add summary for these tables - Chen Nan Li On May 6, 2016, 8:56 a.m., Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-08 Thread Chen Nan Li
Thanks, Chen Nan Li