Review Request 47238: Shifted from a cpu-core model of selection to processing unit model.

2016-05-11 Thread Chris
/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47238/diff/ Testing --- Thanks, Chris

Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

2016-05-11 Thread Chris
--- Thanks, Chris

Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

2016-05-11 Thread Chris
/SubmodularScheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47126/diff/ Testing --- Thanks, Chris

Review Request 47105: Decided to change the default initial task value.

2016-05-09 Thread Chris
/browse/MESOS-5342 Repository: mesos Description --- Decided to change the default initial task value. Diffs - src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47105/diff/ Testing --- Thanks, Chris

Review Request 47120: Value from f() was used when it needs to be the value from map<> cost.

2016-05-09 Thread Chris
ces/hwloc/SubmodularScheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47120/diff/ Testing --- Thanks, Chris

Review Request 47103: Added reference count decrments to core histograms.

2016-05-09 Thread Chris
/hwloc.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47103/diff/ Testing --- Thanks, Chris

Review Request 47101: Process binding using greedy, submodular selection algorithm.

2016-05-09 Thread Chris
://reviews.apache.org/r/47101/diff/ Testing --- Thanks, Chris

Review Request 47100: Process binding using greedy, submodular selection algorithm.

2016-05-09 Thread Chris
/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47100/diff/ Testing --- Thanks, Chris

Review Request 47104: Remove pid from pid-core tracking map.

2016-05-09 Thread Chris
/browse/MESOS-5342 Repository: mesos Description --- Remove pid from pid-core tracking map. Diffs - src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47104/diff/ Testing --- Thanks, Chris

Review Request 47106: Corrected variable names and 'empty' histogram detection logic.

2016-05-09 Thread Chris
/devices/hwloc/hwloc.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47106/diff/ Testing --- Thanks, Chris

Review Request 47102: Corrected initial utilization value for cores.

2016-05-09 Thread Chris
PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47102/diff/ Testing --- Thanks, Chris

Review Request 47126: Forgot the algorithm is maximizing when it needs to minimize.

2016-05-09 Thread Chris
--- The algorithm is maximizing when it needs to minimize. Simple fix after some testing in python. Diffs - src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47126/diff/ Testing --- Thanks, Chris

Review Request 47127: Forgot the algorithm is maximizing when it needs to minimize.

2016-05-09 Thread Chris
--- The algorithm is maximizing when it needs to minimize. Simple fix after some testing in python. Diffs - src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47127/diff/ Testing --- Thanks, Chris

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-07-30 Thread Chris Heller
(potentially). As a test I pulled my branch, and rebased from master, then configured a build and ran `make -j3 distcheck` and was successful in building. Can the auto check be re-run? - Chris Heller On July 29, 2015, 1:41 p.m., Chris Heller wrote

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-08-04 Thread Chris Heller
/ Testing --- See https://github.com/apache/mesos/pull/51 Verified build against statically linked OpenSSL 1.0.1e and Cyrus-SASL 2.1.26 Thanks, Chris Heller

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-08-04 Thread Chris Heller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/#review94054 --- Re-based the PR - Chris Heller On July 29, 2015, 1:41 p.m

Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-07-29 Thread Chris Heller
-SASL 2.1.26 Thanks, Chris Heller

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-07-29 Thread Chris Heller
://reviews.apache.org/r/36910/diff/ Testing --- See https://github.com/apache/mesos/pull/51 Verified build against statically linked OpenSSL 1.0.1e and Cyrus-SASL 2.1.26 Thanks, Chris Heller

Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da Diff: https://reviews.apache.org/r/38815/diff/ Testing --- Tested from upstream; Running mesos check suite currently. Thanks, Chris Chen

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, a

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
, above `PATCH_CMD`. I don't see that file... - Chris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100860 --- On Sept. 28,

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
; Running mesos check succeeds. Thanks, Chris Chen

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
> On Sept. 28, 2015, 11:18 p.m., Mesos ReviewBot wrote: > > Bad review! > > > > Reviews applied: [] > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
; Running mesos check succeeds. Thanks, Chris Chen

Review Request 52593: Mesos is over

2016-10-05 Thread Chris Lambert
Diffs - src/slave/http.cpp bdafe1d src/tests/api_tests.cpp 7b0ad3c Diff: https://reviews.apache.org/r/52593/diff/ Testing --- Thanks, Chris Lambert