Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Felix Abecassis
src/hook/manager.hpp 3af1ff8 src/hook/manager.cpp 108bd46 src/slave/slave.cpp 01c5e42 src/tests/hook_tests.cpp b35ce72 Diff: https://reviews.apache.org/r/38564/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38279: [MESOS-3366] Allow resources/attributes discovery

2015-09-14 Thread Felix Abecassis
/test_hook_module.cpp bc13a8a src/hook/manager.hpp 30d8321 src/hook/manager.cpp 754c238 src/slave/slave.cpp 5e5522e Diff: https://reviews.apache.org/r/38279/diff/ Testing --- make clean && make && make check Thanks, Felix Abecassis

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-14 Thread Felix Abecassis
mp; make && make check Thanks, Felix Abecassis

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
issue to discuss how to fix this? - Felix --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98860 ------- On Sep

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
--- make clean && make && make check Thanks, Felix Abecassis

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
tps://reviews.apache.org/r/38279/#review98886 --- On Sept. 19, 2015, 12:51 a.m., Felix Abecassis wrote: > > --- > This is an automatically generated e-mail.

Review Request 38517: Make attributes.hpp public

2015-09-18 Thread Felix Abecassis
src/tests/registrar_tests.cpp aa49c86 Diff: https://reviews.apache.org/r/38517/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Felix Abecassis
://reviews.apache.org/r/38517/ - Felix Abecassis On Sept. 23, 2015, 6:13 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
: https://reviews.apache.org/r/38564/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Felix Abecassis
> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. > > Felix Abecassis wrote: > Thank you, I hope it's fixed now. > > Guangya Liu wrot

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
://reviews.apache.org/r/38564/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
://reviews.apache.org/r/38564/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
ase verify. - Felix --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99883 --- On Sept. 22, 2015, 1:26 a.m.,

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > <https://reviews.apache.org/r/38279/diff/2/?file=1077263#file1077263line659> > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Fel

Re: Review Request 38279: Add a new callback enabling custom resource discovery logic

2015-09-21 Thread Felix Abecassis
/r/38279/diff/ Testing --- make clean && make && make check Thanks, Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99841 --- On Sept. 21, 2015, 11:22 p.m., Felix Abecassis wrote: > > --- >

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
s://reviews.apache.org/r/38279/#review99733 ------- On Sept. 19, 2015, 12:51 a.m., Felix Abecassis wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
-------- On Sept. 21, 2015, 11:22 p.m., Felix Abecassis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38564/ > -

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
src/examples/test_hook_module.cpp 0dc74d6 src/hook/manager.hpp a517c05 src/hook/manager.cpp 691976e src/slave/slave.cpp 29865ec src/tests/hook_tests.cpp b23a587 Diff: https://reviews.apache.org/r/38279/diff/ Testing --- make clean && make && make check

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
7a54fad src/tests/attributes_tests.cpp ded6120 src/tests/registrar_tests.cpp 5131b57 Diff: https://reviews.apache.org/r/38517/diff/ Testing --- Thanks, Felix Abecassis

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
ail. To reply, visit: https://reviews.apache.org/r/38279/#review99892 ------- On Sept. 22, 2015, 1:26 a.m., Felix Abecassis wrote: > > --- > This is an automat

Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
/ Testing --- Thanks, Felix Abecassis

Review Request 42320: Replaced deprecated Docker flag "-c" with "--cpu-shares"

2016-01-14 Thread Felix Abecassis
/ Testing --- Thanks, Felix Abecassis

Re: Review Request 42320: Replaced deprecated Docker flag "-c" with "--cpu-shares"

2016-01-14 Thread Felix Abecassis
ot;-c" by a bogus value like "--foobar", the tests failed. Thanks, Felix Abecassis

Re: Review Request 42320: Replaced deprecated Docker flag "-c" with "--cpu-shares"

2016-01-14 Thread Felix Abecassis
eply, visit: https://reviews.apache.org/r/42320/#review114571 --- On Jan. 14, 2016, 10:06 p.m., Felix Abecassis wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 42320: Replaced deprecated Docker flag "-c" with "--cpu-shares"

2016-01-14 Thread Felix Abecassis
320/diff/ Testing --- `make check` on my local desktop, the Docker tests did run: [--] 7 tests from DockerTest [ RUN ] DockerTest.ROOT_DOCKER_interface [ OK ] DockerTest.ROOT_DOCKER_interface (8897 ms) Also checked that if I replace "-c" by a bogus value like "--foobar", the tests failed. Thanks, Felix Abecassis