Re: Review Request 33446: Link to mesos-containerizer from the main documentation page.

2015-04-22 Thread Joerg Schad
/#comment131454 Should we mention here that this is the default containerizer? - Joerg Schad On April 22, 2015, 7:22 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33446

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-07 Thread Joerg Schad
does not cause a noticable performance penalty (don't think so, but numbers are always good to verify) - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 33272: Fix capture by reference of temporary strings in Stout.

2015-05-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33272/#review82872 --- Ship it! - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

2015-05-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733/#review82876 --- Ship it! Ship It! - Joerg Schad On April 30, 2015, 10:45 p.m

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-07 Thread Joerg Schad
. - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33274

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Joerg Schad
How is this related to your change? - Joerg Schad On May 7, 2015, 7:09 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-07 Thread Joerg Schad
temporaries) confirming non-noticable performance penalty og these changes would be cool. - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Joerg Schad
On May 7, 2015, 8:07 p.m., Joerg Schad wrote: configure.ac, line 566 https://reviews.apache.org/r/32198/diff/7/?file=952552#file952552line566 How is this related to your change? Looking at the review history could it be that this was added by mistake? - Joerg

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-05-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review82897 --- Ship it! Ship It! - Joerg Schad On April 22, 2015, 9:09 a.m

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-08 Thread Joerg Schad
On May 8, 2015, 3:17 p.m., Joerg Schad wrote: Besides my above comment looks great! Good effort for a more robust codebase! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

2015-05-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733/#review82563 --- LGTM - Joerg Schad On April 30, 2015, 10:45 p.m., Alexander

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Joerg Schad
On May 8, 2015, 8:58 p.m., Joerg Schad wrote: Please add to documentation After that Ship it! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83085

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Joerg Schad
://reviews.apache.org/r/33514/#comment133957 Could you add this flag to the documentation http://mesos.apache.org/documentation/latest/configuration/ - Joerg Schad On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote

Re: Review Request 31838: Fixed authentication failure triggered slave crash.

2015-05-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review83377 --- is this review still active? - Joerg Schad On March 9, 2015, 12

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-05-14 Thread Joerg Schad
/configuration.md https://reviews.apache.org/r/29507/#comment134815 Slaves that incure more than max_slave_ping_timeouts timeouts will be asked to shutdown. - Joerg Schad On May 14, 2015, 10:01 a.m., Adam B wrote

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
/33295/#comment135773 Is that dropped by a rebase or by you? Same below - Joerg Schad On May 20, 2015, 6:39 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: Besides the below mentioned points looks good to me! We should just remember adding this to the libprocess user guide. - Joerg --- This is an automatically generated e-mail. To reply

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: docs/powered-by-mesos.md, line 28 https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28 Is that dropped by a rebase or by you? Same below Thanks for fixing this so quickly :-). - Joerg

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: 3rdparty/libprocess/src/process.cpp, line 373 https://reviews.apache.org/r/33295/diff/4/?file=947285#file947285line373 are universal/rvalue refs allowed by our style guide? If so should we add it to the styleguide? actually

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
this to the libprocess userguide (MESOS-2545) and if you could just add a comment to the Jira to document who approved to the design doc. - Joerg Schad On May 20, 2015, 7:46 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail

Re: Review Request 35207: Included doxygen documentation in docs/home.md.

2015-06-08 Thread Joerg Schad
/ Testing --- Thanks, Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

2015-06-08 Thread Joerg Schad
://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

2015-06-08 Thread Joerg Schad
://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35207: Included doxygen documentation in docs/home.md.

2015-06-08 Thread Joerg Schad
intent), I personally prefere to have the seperate section API Documentation (and we need to add the Doxygen styleguide anyhow). Any preference? - Joerg Schad On June 8, 2015, 8:44 p.m., Joerg Schad wrote: --- This is an automatically

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review86869 --- Ship it! Ship It! - Joerg Schad On June 5, 2015, 1:20 p.m

Re: Review Request 35206: Added mainpage to doxygen documentation.

2015-06-08 Thread Joerg Schad
Diff: https://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35000: Doxygen'ized Subprocess.

2015-06-03 Thread Joerg Schad
/returns/return same for rest of file Great effort, makes understanding Subprocess much simpler! - Joerg Schad On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33331: Added file headers section to the C++ style guide.

2015-06-04 Thread Joerg Schad
/#comment138668 Please make this a list item (same below). pmust or should?/p docs/mesos-c++-style-guide.md https://reviews.apache.org/r/1/#comment138669 must or should? - Joerg Schad On June 4, 2015, 2:37 p.m., Till Toenshoff wrote

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-23 Thread Joerg Schad
/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-23 Thread Joerg Schad
://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 33564: stout: Removed stout/memory.hpp and switched from 'memory::' to 'std::'.

2015-06-22 Thread Joerg Schad
://reviews.apache.org/r/35722/ - Joerg Schad On April 26, 2015, 7:12 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33564

Re: Review Request 35874: Added template parameters and constructors to hashset which reflex the state of hashmap

2015-06-25 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35874/#review89381 --- s/reflex/reflects - Joerg Schad On June 25, 2015, 1:45 p.m

Re: Review Request 35568: Remove html from libprocess Developer Guide.

2015-06-24 Thread Joerg Schad
://reviews.apache.org/r/35568/diff/ Testing --- Rendered version: https://gist.github.com/joerg84/9a7df382292dfc672350 Thanks, Joerg Schad

Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-26 Thread Joerg Schad
/ Testing --- make check (including docker tests) Thanks, Joerg Schad

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

2015-06-26 Thread Joerg Schad
Diff: https://reviews.apache.org/r/35920/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad

Re: Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

2015-06-11 Thread Joerg Schad
/. - Joerg Schad On June 11, 2015, 11:59 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35350/ --- (Updated

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-16 Thread Joerg Schad
Version: Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-16 Thread Joerg Schad
Version: Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35509: Doxygen Style Guide Improvements.

2015-06-16 Thread Joerg Schad
/diff/ Testing --- Rendered Version: https://gist.github.com/joerg84/7039ed2d029470127cea Thanks, Joerg Schad

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-16 Thread Joerg Schad
/35510/diff/ Testing --- Rendered Version: Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-17 Thread Joerg Schad
Version: Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-17 Thread Joerg Schad
, Joerg Schad

Review Request 35553: Rename libprocess User Guide to Developer Guide.

2015-06-17 Thread Joerg Schad
://issues.apache.org/jira/browse/MESOS-2878 Repository: mesos Description --- Rename libprocess User Guide to Developer Guide. Diffs - 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e Diff: https://reviews.apache.org/r/35553/diff/ Testing --- Thanks, Joerg

Re: Review Request 35554: Rename Stout User Guide to Stout Developer Guide.

2015-06-17 Thread Joerg Schad
://reviews.apache.org/r/35554/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35363: Improvements on libprocess/README.md.

2015-06-17 Thread Joerg Schad
/#review88204 --- On June 11, 2015, 8:40 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35363

Re: Review Request 35568: Remove html from libprocess Developer Guide.

2015-06-17 Thread Joerg Schad
/ Testing (updated) --- Rendered version: https://gist.github.com/joerg84/9a7df382292dfc672350 Thanks, Joerg Schad

Review Request 35568: Remove html from libprocess Developer Guide.

2015-06-17 Thread Joerg Schad
--- Remove html from libprocess Developer Guide. Diffs - 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e Diff: https://reviews.apache.org/r/35568/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35568: Remove html from libprocess Developer Guide.

2015-06-17 Thread Joerg Schad
://reviews.apache.org/r/35568/diff/ Testing --- Rendered version: https://gist.github.com/joerg84/9a7df382292dfc672350 Thanks, Joerg Schad

Re: Review Request 35494: Added format for template declaration in the styleguide.

2015-06-16 Thread Joerg Schad
it this way. Most other code I know omits the space. Still, as this seems to be common practice... docs/mesos-c++-style-guide.md (line 62) https://reviews.apache.org/r/35494/#comment140439 Why is this under Class Format? Can't we have: ### Template * Leave - Joerg Schad On June 16

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-12 Thread Joerg Schad
://reviews.apache.org/r/29406/#comment140109 s/the the/ the 3rdparty/libprocess/src/libevent_ssl_socket.cpp https://reviews.apache.org/r/29406/#comment140111 s/scneario/scenario - Joerg Schad On June 12, 2015, 6:06 p.m., Joris Van Remoortere wrote

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

2015-06-02 Thread Joerg Schad
cb45beb98527daa338a98e8a8b6a30730f881c43 Diff: https://reviews.apache.org/r/34565/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 34939: Started Doxygen Style-Guide.

2015-06-02 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 35974: Fix missing new line in ssl_client.

2015-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/#review89633 --- Ship it! - Joerg Schad On June 27, 2015, 7:30 p.m., Joris Van

Review Request 35985: Consistent capitalization of NOTE in documentation

2015-06-28 Thread Joerg Schad
Description --- Consistent capitalization of NOTE in documentation Diffs - docs/mesos-markdown-style-guide.md d5b7804d685e9351c7043611e84dd3498643724c Diff: https://reviews.apache.org/r/35985/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-28 Thread Joerg Schad
3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad

Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joerg Schad
--- Checked rendered markdown. Thanks, Joerg Schad

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Joerg Schad
:-)). - Joerg Schad On July 6, 2015, 12:32 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joerg Schad
--- On July 6, 2015, 9:01 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36193/ --- (Updated July 6, 2015, 9

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

2015-07-01 Thread Joerg Schad
, but I feel this will not add too much additional value. Just pointing out doxygen features :-) - Joerg Schad On June 29, 2015, 11:43 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-05-26 Thread Joerg Schad
/#comment136671 In order to be consistent with other flags (and removes the could): Either a JSON formatted string of rules or a file path src/slave/flags.cpp https://reviews.apache.org/r/33296/#comment136672 s/could/must - Joerg Schad On May 26, 2015, 8:22 a.m., Alexander Rojas wrote

Re: Review Request 34563: Allowed delegating constructors in styleguide.

2015-05-21 Thread Joerg Schad
://reviews.apache.org/r/34563/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 34563: Allowed delegating constructors in styleguide.

2015-05-21 Thread Joerg Schad
/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.

2015-05-21 Thread Joerg Schad
/flags.cpp b5e25186dad36bc1306cc6ecb268aba951a18f7e Diff: https://reviews.apache.org/r/34534/diff/ Testing --- Thanks, Joerg Schad

Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

2015-05-21 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 34563: Allowed delegating constructors in styleguide

2015-05-21 Thread Joerg Schad
Remoortere. Repository: mesos Description (updated) --- Allowed delegating constructors in styleguide. Diffs - docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/34563/diff/ Testing --- Thanks, Joerg Schad

Review Request 34563: Allowed delegating constructors in styleguide

2015-05-21 Thread Joerg Schad
Description --- Allowed delegating constructors in styleguide Diffs - docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/34563/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 36214: Fix running docker executor tests.

2015-07-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36214/#review90665 --- Ship it! - Joerg Schad On July 6, 2015, 8:40 p.m., Timothy Chen

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36205/#review90661 --- Ship it! After fixing my previous issue... - Joerg Schad

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-07 Thread Joerg Schad
://reviews.apache.org/r/36205/#comment143797 Shouldn't this be also two empty lines here? - Joerg Schad On July 6, 2015, 3:44 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36216: Only run netcat tests when nc is available.

2015-07-07 Thread Joerg Schad
://reviews.apache.org/r/36216/#comment143800 Should we comment about NC? (see above) - Joerg Schad On July 6, 2015, 10:58 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-08-13 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing (updated) --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-08-13 Thread Joerg Schad
. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 --- On July 24, 2015, 1:07 p.m., Joerg Schad wrote

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-24 Thread Joerg Schad
/36620/#review96144 --- On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-20 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-29 Thread Joerg Schad
: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad

Review Request 35920: Change EXPECT to ASSERT when relying in the assertion afterwards.

2015-06-26 Thread Joerg Schad
, Joerg Schad

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

2015-06-26 Thread Joerg Schad
3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35920/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
3772e39015a22655dcad00ad844dc5ddc90db43f src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a src/master/quota_handler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
-CREATION src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/#review93473 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 4:58 p.m

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
. MESOS-3163 - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93175 --- On July 28, 2015, 9:49 a.m., Joerg Schad wrote

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
d1685799f4c53e067d0812e037e171324ee7195f 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36883: Fixed a typo in oversubscription doc.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36883/#review93266 --- Ship it! Ship It! - Joerg Schad On July 28, 2015, 9:17 a.m

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93261 --- On July 28, 2015, 9:49 a.m., Joerg Schad wrote: --- This is an automatically generated e

Re: Review Request 36847: WIP: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
Thanks, Joerg Schad

Re: Review Request 36847: WIP: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
, Joerg Schad

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Joerg Schad
bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36889/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Joerg Schad
--- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94030 --- On Aug. 4, 2015, 9:52 a.m., Joerg Schad wrote

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
3772e39015a22655dcad00ad844dc5ddc90db43f src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: WIP: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Joerg Schad
Description --- FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome. Diffs - src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36889/diff/ Testing --- make check Thanks, Joerg

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Joerg Schad
On July 28, 2015, 11:42 a.m., Joerg Schad wrote: docs/fetcher-cache-internals.md, line 107 https://reviews.apache.org/r/36773/diff/3/?file=1022381#file1022381line107 removes the *most* recently used first Sorry meant something along the lines: Cache eviction removes the cache

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Joerg Schad
bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36889/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Joerg Schad
/#comment147651 Just as a comment: I find cacheSize() very unintuive name for this function, would have expected something along cacheFiles().size() or numberEntries() - Joerg Schad On July 27, 2015, 3:38 p.m., Jan Schlicht wrote

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Joerg Schad
://reviews.apache.org/r/36773/#comment147794 ++taskIndex - Joerg Schad On July 28, 2015, 2:04 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

  1   2   3   4   5   6   7   8   9   10   >