does not cause a
noticable performance penalty (don't think so, but numbers are always good to
verify)
- Joerg Schad
On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33733/#review82876
---
Ship it!
Ship It!
- Joerg Schad
On April 30, 2015, 10:45 p.m
.
- Joerg Schad
On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33274
On May 7, 2015, 8:07 p.m., Joerg Schad wrote:
configure.ac, line 566
https://reviews.apache.org/r/32198/diff/7/?file=952552#file952552line566
How is this related to your change?
Looking at the review history could it be that this was added by mistake?
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review82897
---
Ship it!
Ship It!
- Joerg Schad
On April 22, 2015, 9:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33733/#review82563
---
LGTM
- Joerg Schad
On April 30, 2015, 10:45 p.m., Alexander
On May 8, 2015, 8:58 p.m., Joerg Schad wrote:
Please add to documentation
After that Ship it!
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83085
On May 20, 2015, 7:18 a.m., Joerg Schad wrote:
docs/powered-by-mesos.md, line 28
https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28
Is that dropped by a rebase or by you?
Same below
Thanks for fixing this so quickly :-).
- Joerg
/
Testing
---
Thanks,
Joerg Schad
://reviews.apache.org/r/35206/diff/
Testing
---
Thanks,
Joerg Schad
://reviews.apache.org/r/35206/diff/
Testing
---
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35131/#review86869
---
Ship it!
Ship It!
- Joerg Schad
On June 5, 2015, 1:20 p.m
Diff: https://reviews.apache.org/r/35206/diff/
Testing
---
Thanks,
Joerg Schad
/returns/return
same for rest of file
Great effort, makes understanding Subprocess much simpler!
- Joerg Schad
On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment138668
Please make this a list item (same below).
pmust or should?/p
docs/mesos-c++-style-guide.md
https://reviews.apache.org/r/1/#comment138669
must or should?
- Joerg Schad
On June 4, 2015, 2:37 p.m., Till Toenshoff wrote
/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
://gist.github.com/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
://reviews.apache.org/r/35722/
- Joerg Schad
On April 26, 2015, 7:12 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33564
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/#review89381
---
s/reflex/reflects
- Joerg Schad
On June 25, 2015, 1:45 p.m
://reviews.apache.org/r/35568/diff/
Testing
---
Rendered version:
https://gist.github.com/joerg84/9a7df382292dfc672350
Thanks,
Joerg Schad
/
Testing
---
make check (including docker tests)
Thanks,
Joerg Schad
Diff: https://reviews.apache.org/r/35920/diff/
Testing
---
make check (including docker tests)
Thanks,
Joerg Schad
/.
- Joerg Schad
On June 11, 2015, 11:59 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35350/
---
(Updated
Version:
Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e
Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
Version:
Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e
Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
/diff/
Testing
---
Rendered Version:
https://gist.github.com/joerg84/7039ed2d029470127cea
Thanks,
Joerg Schad
/35510/diff/
Testing
---
Rendered Version:
Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e
Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
Version:
Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e
Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e
Thanks,
Joerg Schad
://issues.apache.org/jira/browse/MESOS-2878
Repository: mesos
Description
---
Rename libprocess User Guide to Developer Guide.
Diffs
-
3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
Diff: https://reviews.apache.org/r/35553/diff/
Testing
---
Thanks,
Joerg
://reviews.apache.org/r/35554/diff/
Testing
---
Thanks,
Joerg Schad
/#review88204
---
On June 11, 2015, 8:40 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363
/
Testing (updated)
---
Rendered version:
https://gist.github.com/joerg84/9a7df382292dfc672350
Thanks,
Joerg Schad
---
Remove html from libprocess Developer Guide.
Diffs
-
3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
Diff: https://reviews.apache.org/r/35568/diff/
Testing
---
Thanks,
Joerg Schad
://reviews.apache.org/r/35568/diff/
Testing
---
Rendered version:
https://gist.github.com/joerg84/9a7df382292dfc672350
Thanks,
Joerg Schad
it this way. Most other
code I know omits the space. Still, as this seems to be common practice...
docs/mesos-c++-style-guide.md (line 62)
https://reviews.apache.org/r/35494/#comment140439
Why is this under Class Format? Can't we have:
### Template
* Leave
- Joerg Schad
On June 16
cb45beb98527daa338a98e8a8b6a30730f881c43
Diff: https://reviews.apache.org/r/34565/diff/
Testing
---
Thanks,
Joerg Schad
---
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35974/#review89633
---
Ship it!
- Joerg Schad
On June 27, 2015, 7:30 p.m., Joris Van
Description
---
Consistent capitalization of NOTE in documentation
Diffs
-
docs/mesos-markdown-style-guide.md d5b7804d685e9351c7043611e84dd3498643724c
Diff: https://reviews.apache.org/r/35985/diff/
Testing
---
Thanks,
Joerg Schad
3a983c6813dab6fa03ccb2c87e1ea71866766d6e
Diff: https://reviews.apache.org/r/35927/diff/
Testing
---
make check (including docker tests)
Thanks,
Joerg Schad
---
Checked rendered markdown.
Thanks,
Joerg Schad
:-)).
- Joerg Schad
On July 6, 2015, 12:32 p.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197
---
On July 6, 2015, 9:01 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36193/
---
(Updated July 6, 2015, 9
, but I feel this will not
add too much additional value.
Just pointing out doxygen features :-)
- Joerg Schad
On June 29, 2015, 11:43 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/diff/
Testing
---
Thanks,
Joerg Schad
/flags.cpp b5e25186dad36bc1306cc6ecb268aba951a18f7e
Diff: https://reviews.apache.org/r/34534/diff/
Testing
---
Thanks,
Joerg Schad
---
Thanks,
Joerg Schad
Description
---
Allowed delegating constructors in styleguide
Diffs
-
docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69
Diff: https://reviews.apache.org/r/34563/diff/
Testing
---
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90665
---
Ship it!
- Joerg Schad
On July 6, 2015, 8:40 p.m., Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36205/#review90661
---
Ship it!
After fixing my previous issue...
- Joerg Schad
://reviews.apache.org/r/36205/#comment143797
Shouldn't this be also two empty lines here?
- Joerg Schad
On July 6, 2015, 3:44 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/36216/#comment143800
Should we comment about NC? (see above)
- Joerg Schad
On July 6, 2015, 10:58 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
Diff: https://reviews.apache.org/r/36620/diff/
Testing (updated)
---
sudo make check
+ manual tests
Thanks,
Joerg Schad
.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review93329
---
On July 24, 2015, 1:07 p.m., Joerg Schad wrote
/36620/#review96144
---
On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
Diff: https://reviews.apache.org/r/36620/diff/
Testing
---
sudo make check
+ manual tests
Thanks,
Joerg Schad
: https://reviews.apache.org/r/35927/diff/
Testing
---
make check (including docker tests)
Thanks,
Joerg Schad
,
Joerg Schad
3a983c6813dab6fa03ccb2c87e1ea71866766d6e
Diff: https://reviews.apache.org/r/35920/diff/
Testing
---
make check (including docker tests)
Thanks,
Joerg Schad
3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b
src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a
src/master/quota_handler.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
-CREATION
src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332
Diff: https://reviews.apache.org/r/36908/diff/
Testing
---
make distcheck
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36916/#review93473
---
Ship it!
Ship It!
- Joerg Schad
On July 29, 2015, 4:58 p.m
.
MESOS-3163
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93175
---
On July 28, 2015, 9:49 a.m., Joerg Schad wrote
d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp
01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36883/#review93266
---
Ship it!
Ship It!
- Joerg Schad
On July 28, 2015, 9:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93261
---
On July 28, 2015, 9:49 a.m., Joerg Schad wrote:
---
This is an automatically generated e
Thanks,
Joerg Schad
,
Joerg Schad
bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
---
make check
Thanks,
Joerg Schad
.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94030
---
On Aug. 4, 2015, 9:52 a.m., Joerg Schad wrote
3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp
01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
---
make check
Thanks,
Joerg Schad
On July 28, 2015, 11:42 a.m., Joerg Schad wrote:
docs/fetcher-cache-internals.md, line 107
https://reviews.apache.org/r/36773/diff/3/?file=1022381#file1022381line107
removes the *most* recently used first
Sorry meant something along the lines: Cache eviction removes the cache
bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
---
make check
Thanks,
Joerg Schad
/#comment147651
Just as a comment: I find cacheSize() very unintuive name for this
function, would have expected something along cacheFiles().size() or
numberEntries()
- Joerg Schad
On July 27, 2015, 3:38 p.m., Jan Schlicht wrote
://reviews.apache.org/r/36773/#comment147794
++taskIndex
- Joerg Schad
On July 28, 2015, 2:04 p.m., Jan Schlicht wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773
9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp
01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
---
make check
Thanks,
Joerg Schad
d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp
01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93438
---
Ship it!
Ship It!
- Joerg Schad
On July 29, 2015, 11:52 a.m
---
On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908
bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/#review94216
---
Ship it!
Ship It!
- Joerg Schad
On Aug. 5, 2015, 9:35 a.m
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
Diff: https://reviews.apache.org/r/36908/diff/
Testing
---
make distcheck
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93886
---
Ship it!
Ship It!
- Joerg Schad
On Aug. 3, 2015, 8:43 a.m., Jan
---
On July 29, 2015, 1:39 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847
b8d930058aa3ae9d21ae0f7b420d49f2448f84b1
3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166
3rdparty/libprocess/src/tests/http_tests.cpp
ecbcbd552ac834659860627c82628ed38e6139b3
Diff: https://reviews.apache.org/r/36847/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
Diff: https://reviews.apache.org/r/36908/diff/
Testing
---
make distcheck
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93923
---
On July 29, 2015, 1:39 p.m., Joerg Schad wrote
://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b
src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a
src/master/quota_handler.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
:
https://reviews.apache.org/r/36847/#review94388
---
On Aug. 4, 2015, 10:57 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment149277
Could we please add this flag to the documentation i.e. configuration.md
- Joerg Schad
On Aug. 5, 2015, 9:15 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment150347
s/framework/framework.
- Joerg Schad
On Aug. 13, 2015, 8:20 p.m., James DeFelice wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443
://reviews.apache.org/r/36620/diff/
Testing
---
sudo make check
Thanks,
Joerg Schad
---
checked rendered version.
Thanks,
Joerg Schad
---
On July 24, 2015, 1:07 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620
.
Changes
---
Style fixes
Repository: mesos
Description
---
WIP Added Non-Freezeer Task Killer.
Diffs (updated)
-
src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e
Diff: https://reviews.apache.org/r/36620/diff/
Testing
---
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
WIP Added Non-Freezeer Task Killer.
Diffs (updated)
-
src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e
Diff: https://reviews.apache.org/r/36620/diff/
Testing
---
Thanks,
Joerg Schad
1 - 100 of 1024 matches
Mail list logo
