Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review84005 --- Patch looks great! Reviews applied: [34298, 33865] All tests passe

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review84002 --- Ship it! src/master/validation.cpp

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/ --- (Updated May 15, 2015, 11:28 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

> On May 15, 2015, 7:18 p.m., Jie Yu wrote: > > src/master/validation.cpp, lines 89-91 > > > > > > Revocable resources shouldn't be used with Persistent volume. We might > > want to support temp volume in the future an

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

> On May 15, 2015, 6:09 p.m., Niklas Nielsen wrote: > > src/master/validation.cpp, line 90 > > > > > > Do you want to stringify the resource for the error message here too? wanted to be consistent with the rest of the

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review83962 --- Ship it! src/master/validation.cpp

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review83954 --- Ship it! src/master/validation.cpp

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review83880 --- Patch looks great! Reviews applied: [33865] All tests passed. - M

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/ --- (Updated May 14, 2015, 11:57 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

> On May 7, 2015, 12:38 a.m., Jie Yu wrote: > > include/mesos/mesos.proto, lines 454-458 > > > > > > Chatted with Vinod offline (PS: Vinod is going to send out a summary of > > the discussion). > > > > In sho

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review82763 --- include/mesos/mesos.proto

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review82594 --- Patch looks great! Reviews applied: [33865] All tests passed. - M