Re: Review Request 34152: Master flag validation now supports zookeeper

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34152/#review141453
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 13, 2015, 5:50 p.m., Tom Arnfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34152/
> ---
> 
> (Updated May 13, 2015, 5:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-2723
> https://issues.apache.org/jira/browse/MESOS-2723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-execute cli tool does custom validation on the --master flag
> to improve user error handling, but currently does not support ZooKeeper.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 
> 
> Diff: https://reviews.apache.org/r/34152/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tested locally on a live cluster, with both ZooKeeper and 
> standalone host:port.
> 
> 
> Thanks,
> 
> Tom Arnfeld
> 
>

Re: Review Request 34152: Master flag validation now supports zookeeper

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34152/#review83639
---



src/cli/execute.cpp


This needs to be updated. See src/slave/main.cpp for an appropriate error 
message.



src/cli/execute.cpp


Instead of doing it this way, I would recommend doing it the way 
MasterDetector::create() does the URL parsing (see src/master/detector.cpp) for 
consistency.


- Vinod Kone


On May 13, 2015, 5:50 p.m., Tom Arnfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34152/
> ---
> 
> (Updated May 13, 2015, 5:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-2723
> https://issues.apache.org/jira/browse/MESOS-2723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-execute cli tool does custom validation on the --master flag
> to improve user error handling, but currently does not support ZooKeeper.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 
> 
> Diff: https://reviews.apache.org/r/34152/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tested locally on a live cluster, with both ZooKeeper and 
> standalone host:port.
> 
> 
> Thanks,
> 
> Tom Arnfeld
> 
>

Re: Review Request 34152: Master flag validation now supports zookeeper

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34152/#review83568
---


Patch looks great!

Reviews applied: [34152]

All tests passed.

- Mesos ReviewBot


On May 13, 2015, 2:08 a.m., Tom Arnfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34152/
> ---
> 
> (Updated May 13, 2015, 2:08 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2723
> https://issues.apache.org/jira/browse/MESOS-2723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-execute cli tool does custom validation on the --master flag
> to improve user error handling, but currently does not support ZooKeeper.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 
> 
> Diff: https://reviews.apache.org/r/34152/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tested locally on a live cluster, with both ZooKeeper and 
> standalone host:port.
> 
> 
> Thanks,
> 
> Tom Arnfeld
> 
>