Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86545
---


Bad patch!

Reviews applied: [34962, 34980]

Failed command: ./support/apply-review.sh -n -r 34980

Error:
 2015-06-04 03:47:48 URL:https://reviews.apache.org/r/34980/diff/raw/ 
[5661/5661] -> "34980.patch" [1]
error: patch failed: include/mesos/slave/resource_estimator.hpp:25
error: include/mesos/slave/resource_estimator.hpp: patch does not apply
error: patch failed: src/slave/resource_estimators/noop.hpp:21
error: src/slave/resource_estimators/noop.hpp: patch does not apply
error: patch failed: src/slave/resource_estimators/noop.cpp:59
error: src/slave/resource_estimators/noop.cpp: patch does not apply
error: patch failed: src/slave/slave.cpp:323
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/mesos.hpp:715
error: src/tests/mesos.hpp: patch does not apply
error: patch failed: src/tests/oversubscription_tests.cpp:87
error: src/tests/oversubscription_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On June 4, 2015, 12:08 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 4, 2015, 12:08 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 
> 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---

(Updated June 4, 2015, 12:08 a.m.)


Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
Kone.


Changes
---

Wrap too long lines.


Bugs: MESOS-2773
https://issues.apache.org/jira/browse/MESOS-2773


Repository: mesos


Description
---

Pass callback to the resource estimator to retrieve ResourceUsage from Resource 
Monitor on demand.

This is neccessary, since ResourceEstimator needs data (current statistics for 
each executor) on which it will base its slack predictions.


Diffs (updated)
-

  include/mesos/slave/resource_estimator.hpp 
e7f5decdabdfc75587d784a08a98c62ffdfc2909 
  src/slave/resource_estimators/noop.hpp 
2234ed6da17346c74c2e232ff9eae501531515e1 
  src/slave/resource_estimators/noop.cpp 
3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
  src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
  src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
  src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 

Diff: https://reviews.apache.org/r/34980/diff/


Testing
---

make check


Thanks,

Bartek Plotka

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---

(Updated June 3, 2015, 11:10 p.m.)


Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
Kone.


Bugs: MESOS-2773
https://issues.apache.org/jira/browse/MESOS-2773


Repository: mesos


Description
---

Pass callback to the resource estimator to retrieve ResourceUsage from Resource 
Monitor on demand.

This is neccessary, since ResourceEstimator needs data (current statistics for 
each executor) on which it will base its slack predictions.


Diffs (updated)
-

  include/mesos/slave/resource_estimator.hpp 
e7f5decdabdfc75587d784a08a98c62ffdfc2909 
  src/slave/resource_estimators/noop.hpp 
2234ed6da17346c74c2e232ff9eae501531515e1 
  src/slave/resource_estimators/noop.cpp 
3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
  src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
  src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
  src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 

Diff: https://reviews.apache.org/r/34980/diff/


Testing
---

make check


Thanks,

Bartek Plotka

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86497
---



src/slave/resource_estimators/noop.cpp


Do you need this, if you pass it along to the process immediately?


- Niklas Nielsen


On June 3, 2015, 3:21 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 3:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 
> 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86496
---

Ship it!


Ship It!

- Niklas Nielsen


On June 3, 2015, 3:21 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 3:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 
> 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---

(Updated June 3, 2015, 10:21 p.m.)


Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
Kone.


Changes
---

s/usages/_usages/


Bugs: MESOS-2773
https://issues.apache.org/jira/browse/MESOS-2773


Repository: mesos


Description
---

Pass callback to the resource estimator to retrieve ResourceUsage from Resource 
Monitor on demand.

This is neccessary, since ResourceEstimator needs data (current statistics for 
each executor) on which it will base its slack predictions.


Diffs (updated)
-

  include/mesos/slave/resource_estimator.hpp 
e7f5decdabdfc75587d784a08a98c62ffdfc2909 
  src/slave/resource_estimators/noop.hpp 
2234ed6da17346c74c2e232ff9eae501531515e1 
  src/slave/resource_estimators/noop.cpp 
3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
  src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
  src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
  src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 

Diff: https://reviews.apache.org/r/34980/diff/


Testing
---

make check


Thanks,

Bartek Plotka

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86490
---

Ship it!



src/slave/resource_estimators/noop.cpp


`s/usages_/_usages/`


- Jie Yu


On June 3, 2015, 9:16 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 
> 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

> On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote:
> > Do you want to add a test to verify that this works? :)

Definitely will do that in next patch (:


- Bartek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86464
---


On June 3, 2015, 9:16 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 
> 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---

(Updated June 3, 2015, 9:16 p.m.)


Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
Kone.


Changes
---

Issue addressed. Dropping defer.


Bugs: MESOS-2773
https://issues.apache.org/jira/browse/MESOS-2773


Repository: mesos


Description
---

Pass callback to the resource estimator to retrieve ResourceUsage from Resource 
Monitor on demand.

This is neccessary, since ResourceEstimator needs data (current statistics for 
each executor) on which it will base its slack predictions.


Diffs (updated)
-

  include/mesos/slave/resource_estimator.hpp 
e7f5decdabdfc75587d784a08a98c62ffdfc2909 
  src/slave/resource_estimators/noop.hpp 
2234ed6da17346c74c2e232ff9eae501531515e1 
  src/slave/resource_estimators/noop.cpp 
3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
  src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
  src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
  src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 

Diff: https://reviews.apache.org/r/34980/diff/


Testing
---

make check


Thanks,

Bartek Plotka

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86464
---


Do you want to add a test to verify that this works? :)


include/mesos/slave/resource_estimator.hpp


s/in /in the /



include/mesos/slave/resource_estimator.hpp


s/current/the current/



src/slave/slave.cpp


Do you want to bring the monitor in the environment, explicitly?

```
[monitor]() -> Future> {

}
```


- Niklas Nielsen


On June 2, 2015, 10:56 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 2, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

> On June 3, 2015, 5:58 a.m., Bartek Plotka wrote:
> > Any idea why review requests failed to show diff of noop.hpp?
> > 
> > I guess it something with 
> > https://reviews.apache.org/r/34962/diff/#file976910,  since this patch 
> > depends on that.
> 
> Bartek Plotka wrote:
> reviewboard*

Now it works - seems to be a cache/mirror issue (:


- Bartek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86362
---


On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86441
---



src/slave/slave.cpp


Hum, this looks buggy to me. You copy the 'monitor' instance, which means 
its internal member 'process' will be deleted twice.

I think we might want to make ResourceMonitor a pointer and make sure its 
life time is longer than the resource estimator.


- Jie Yu


On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86366
---


Patch looks great!

Reviews applied: [34962, 34980]

All tests passed.

- Mesos ReviewBot


On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

> On June 3, 2015, 5:58 a.m., Bartek Plotka wrote:
> > Any idea why review requests failed to show diff of noop.hpp?
> > 
> > I guess it something with 
> > https://reviews.apache.org/r/34962/diff/#file976910,  since this patch 
> > depends on that.

reviewboard*


- Bartek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86362
---


On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

[Bartek Plotka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86362
---


Any idea why review requests failed to show diff of noop.hpp?

I guess it something with https://reviews.apache.org/r/34962/diff/#file976910,  
since this patch depends on that.

- Bartek Plotka


On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> ---
> 
> (Updated June 3, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2773
> https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from 
> Resource Monitor on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics 
> for each executor) on which it will base its slack predictions.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 
> e7f5decdabdfc75587d784a08a98c62ffdfc2909 
>   src/slave/resource_estimators/noop.hpp 
> 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp PRE-CREATION 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>