Re: Review Request 35264: Added a slave integration test in MonitorTest.

> On June 11, 2015, 6:40 p.m., Niklas Nielsen wrote: > > src/tests/monitor_tests.cpp, line 22 > > > > > > C-style include before C++ includes :) This is a C++ header:) - Jie

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87599 --- Ship it! src/tests/monitor_tests.cpp

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/ --- (Updated June 10, 2015, 11:13 p.m.) Review request for mesos, Ben Mahler, Nikla

Re: Review Request 35264: Added a slave integration test in MonitorTest.

> On June 10, 2015, 9:58 p.m., Ben Mahler wrote: > > src/tests/monitor_tests.cpp, line 243 > > > > > > This case is still ok for taking a const &, since it's not a temporary. Fixed. > On June 10, 2015, 9:58 p.m., Be

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87468 --- Ship it! src/tests/monitor_tests.cpp

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/ --- (Updated June 10, 2015, 6:30 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87332 --- Patch looks great! Reviews applied: [35259, 35260, 35264] All test

Re: Review Request 35264: Added a slave integration test in MonitorTest.

> On June 9, 2015, 10:12 p.m., Niklas Nielsen wrote: > > src/tests/monitor_tests.cpp, line 221 > > > > > > 77 lines of straight line code; Can we easen up a bit and add structure > > with some comments explaining what

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87308 --- LGTM modulo commenting on the sequence. Also, could we model a JSON