Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-08-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review96798 --- Ship it! Ship It! - Timothy Chen On Aug. 27, 2015, 11 p.m., Lily

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-08-27 Thread Timothy Chen
> On June 16, 2015, 10:02 p.m., Ben Mahler wrote: > > High level review, why don't we just have an abstraction for limiting the > > number of concurrent operations? > > > > You could keep this abstraction local to this file for now and consider > > pulling it out into libprocess. > > For examp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-08-27 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated Aug. 27, 2015, 11 p.m.) Review request for mesos and Timothy Chen. C

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Lily Chen
> On June 16, 2015, 10:02 p.m., Ben Mahler wrote: > > High level review, why don't we just have an abstraction for limiting the > > number of concurrent operations? > > > > You could keep this abstraction local to this file for now and consider > > pulling it out into libprocess. > > For examp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Timothy Chen
> On June 16, 2015, 10:02 p.m., Ben Mahler wrote: > > High level review, why don't we just have an abstraction for limiting the > > number of concurrent operations? > > > > You could keep this abstraction local to this file for now and consider > > pulling it out into libprocess. > > For examp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Jie Yu
> On June 16, 2015, 10:02 p.m., Ben Mahler wrote: > > High level review, why don't we just have an abstraction for limiting the > > number of concurrent operations? > > > > You could keep this abstraction local to this file for now and consider > > pulling it out into libprocess. > > For examp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review88134 --- High level review, why don't we just have an abstraction for limitin

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review88133 --- src/docker/docker.cpp (line 887)

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-16 Thread Lily Chen
> On June 13, 2015, 5:58 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 834 > > > > > > this too? doesn't fit on 80 lines > On June 13, 2015, 5:58 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87802 --- src/docker/docker.cpp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87645 --- Patch looks great! Reviews applied: [35330] All tests passed. - M

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-11 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 9:39 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87503 --- src/docker/docker.cpp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87504 --- Patch looks great! Reviews applied: [35330] All tests passed. - M

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 12:04 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 12:01 a.m.) Review request for mesos and Timothy Chen.