Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88788 --- Ship it! Ship It! - Till Toenshoff On June 17, 2015, 2:28 p.m.,

Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.

2015-06-18 Thread Benjamin Hindman
> On June 17, 2015, 8:32 p.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/launch.cpp, line 221 > > > > > > Does this TODO refer to a "clean environment" as being an environment > > without anything being

Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.

2015-06-17 Thread Till Toenshoff
> On June 17, 2015, 8:32 p.m., Till Toenshoff wrote: > > Would it make sense to have this RR as being the last in this chain? That > > way we could be safely commit earlier RRs without breaking the build. Oops, I meant to say the above for the next RR (35563) - Till

Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.

2015-06-17 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88272 --- Would it make sense to have this RR as being the last in this chain?