Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88875 --- Ship it! let us definitely improve the info pointer management, there is 7 'delete info' in this file right now... :( - Chi Zhang On June 22, 2015, 11:29 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:29 p.m.) Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Fixed a memory bug in port mapping recovery logic. Info will be deleted in `_cleanup` (a little weired, we can fix that later). Diffs - src/slave/containerizer/isolators/network/port_mapping.cpp 4de737a158da2ab329de7c57b9b52de305606bf0 Diff: https://reviews.apache.org/r/35749/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:29 p.m.) Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Changes --- Added a TODO. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Fixed a memory bug in port mapping recovery logic. Info will be deleted in `_cleanup` (a little weired, we can fix that later). Diffs (updated) - src/slave/containerizer/isolators/network/port_mapping.cpp 4de737a158da2ab329de7c57b9b52de305606bf0 Diff: https://reviews.apache.org/r/35749/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.
On June 22, 2015, 11:19 p.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1905-1909 https://reviews.apache.org/r/35749/diff/1/?file=989997#file989997line1905 Do we need another for loop here to clean up unknownOrphans like you did above? No, we cannot, because Info in 'unknownOrphans' might have been already deleted. This whole 'delete Info' thing needs to be refactored. Let's do that later. I'll add a TODO here. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88871 --- On June 22, 2015, 11:08 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:08 p.m.) Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Fixed a memory bug in port mapping recovery logic. Info will be deleted in `_cleanup` (a little weired, we can fix that later). Diffs - src/slave/containerizer/isolators/network/port_mapping.cpp 4de737a158da2ab329de7c57b9b52de305606bf0 Diff: https://reviews.apache.org/r/35749/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.
On June 22, 2015, 11:33 p.m., Chi Zhang wrote: let us definitely improve the info pointer management, there is 7 'delete info' in this file right now... :( Yeah, I'll follow up with patches. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88875 --- On June 22, 2015, 11:29 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:29 p.m.) Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Fixed a memory bug in port mapping recovery logic. Info will be deleted in `_cleanup` (a little weired, we can fix that later). Diffs - src/slave/containerizer/isolators/network/port_mapping.cpp 4de737a158da2ab329de7c57b9b52de305606bf0 Diff: https://reviews.apache.org/r/35749/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88871 --- src/slave/containerizer/isolators/network/port_mapping.cpp (lines 1905 - 1909) https://reviews.apache.org/r/35749/#comment141456 Do we need another for loop here to clean up unknownOrphans like you did above? - Chi Zhang On June 22, 2015, 11:08 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:08 p.m.) Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Fixed a memory bug in port mapping recovery logic. Info will be deleted in `_cleanup` (a little weired, we can fix that later). Diffs - src/slave/containerizer/isolators/network/port_mapping.cpp 4de737a158da2ab329de7c57b9b52de305606bf0 Diff: https://reviews.apache.org/r/35749/diff/ Testing --- sudo make check Thanks, Jie Yu
