Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-07-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review90016 --- src/master/master.cpp (line 1672)

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-07-01 Thread Vinod Kone
On June 25, 2015, 8:25 a.m., Marco Massenzio wrote: src/master/master.cpp, line 2831 https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line2831 not sure this is allowed in our code style, but this could be a good place for `nullptr` Also: shouldn't we

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- (Updated July 1, 2015, 5:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review89691 --- Ship it! src/master/master.cpp (line 2242)

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
On June 25, 2015, 3:57 a.m., Isabel Jimenez wrote: src/master/master.cpp, line 1654 https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line1654 could we have here consistent braces syntax with scheduler.cpp switch case? Perhaps for consistency, and safety, we just

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-25 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review89331 --- Ship it! src/master/master.cpp (line 2826)

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- (Updated June 25, 2015, 1:11 a.m.) Review request for mesos, Anand Mazumdar,