Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-09-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review97894 --- src/master/http.cpp (lines 1909 - 1914)

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-09-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review97909 --- src/master/http.cpp (lines 1909 - 1914)

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-09-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Sept. 4, 2015, 11:20 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review90790 --- Ship it! LGTM! - Jie Yu On Aug. 5, 2015, 7:12 p.m., Michael

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 9:54 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 11:15 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 7:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-31 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated July 31, 2015, 9:57 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-29 Thread Alexander Rukletsov
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: src/master/http.cpp, lines 1325-1332 https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325 Why do we need to recover resources for unreserve? Michael Park wrote: If reserved resources are offered, we

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-28 Thread Alexander Rukletsov
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: src/master/http.cpp, lines 1325-1332 https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325 Why do we need to recover resources for unreserve? Michael Park wrote: If reserved resources are offered, we

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-28 Thread Alexander Rukletsov
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: src/master/http.cpp, line 1291 https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1291 As in https://reviews.apache.org/r/35702/, I suggest we extract validation into a separate function. Michael Park

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-28 Thread Alexander Rukletsov
On July 2, 2015, 3:39 p.m., Alexander Rukletsov wrote: A high level question: do operators have the possibility to get a list of all dynamic reservations? I think about a situation, when a framework made some reservations and then quit, an operator wants to clean up those

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated July 28, 2015, 9:06 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-28 Thread Michael Park
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: src/master/http.cpp, lines 1325-1332 https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325 Why do we need to recover resources for unreserve? Michael Park wrote: If reserved resources are offered, we

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-27 Thread Michael Park
On July 2, 2015, 3:39 p.m., Alexander Rukletsov wrote: A high level question: do operators have the possibility to get a list of all dynamic reservations? I think about a situation, when a framework made some reservations and then quit, an operator wants to clean up those

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-27 Thread Michael Park
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: src/master/http.cpp, lines 1325-1332 https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325 Why do we need to recover resources for unreserve? If reserved resources are offered, we need to recover the

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review91890 --- src/master/http.cpp (line 1291)

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review90235 --- A high level question: do operators have the possibility to get a