Re: Review Request 36112: perf: extracted out a 'version' function.

2015-07-02 Thread Chi Zhang
> On July 1, 2015, 11:19 p.m., Paul Brett wrote: > > src/linux/perf.cpp, line 456 > > > > > > Not your code but we should propagate the failure to the caller so that > > sample can fail rather than halt and catch fire

Re: Review Request 36112: perf: extracted out a 'version' function.

2015-07-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/#review90168 --- src/linux/perf.cpp (lines 448 - 458)

Re: Review Request 36112: perf: extracted out a 'version' function.

2015-07-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/#review90159 --- src/linux/perf.cpp (line 454)