Re: Review Request 36112: perf: extracted out a 'version' function.

[Chi Zhang]

> On July 1, 2015, 11:19 p.m., Paul Brett wrote:
> > src/linux/perf.cpp, line 456
> > 
> >
> > Not your code but we should propagate the failure to the caller so that 
> > sample can fail rather than halt and catch fire here.

dropped this diff


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/#review90159
---


On July 1, 2015, 10:43 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36112/
> ---
> 
> (Updated July 1, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: MESOS-2834
> https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> perf: extracted out a 'version' function.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
> 
> Diff: https://reviews.apache.org/r/36112/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 36112: perf: extracted out a 'version' function.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/#review90168
---



src/linux/perf.cpp (lines 448 - 458)


See subsequent review, I don't think this needs to be pulled out into a 
separate function.


- Ian Downes


On July 1, 2015, 3:43 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36112/
> ---
> 
> (Updated July 1, 2015, 3:43 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: MESOS-2834
> https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> perf: extracted out a 'version' function.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
> 
> Diff: https://reviews.apache.org/r/36112/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 36112: perf: extracted out a 'version' function.

[Paul Brett]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36112/#review90159
---



src/linux/perf.cpp (line 454)


Not your code but we should propagate the failure to the caller so that 
sample can fail rather than halt and catch fire here.


- Paul Brett


On July 1, 2015, 10:43 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36112/
> ---
> 
> (Updated July 1, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: MESOS-2834
> https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> perf: extracted out a 'version' function.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
> 
> Diff: https://reviews.apache.org/r/36112/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>