Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91532 --- Patch looks great! Reviews applied: [36424, 36378, 36380] All test

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-13 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/ --- (Updated July 13, 2015, 9:05 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-13 Thread Paul Brett
> On July 10, 2015, 9:43 p.m., Ian Downes wrote: > > src/tests/perf_tests.cpp, line 159 > > > > > > Do you need to keep all the logging of the context on failed > > expectations after the test has been correctly wr

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-10 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91346 --- src/tests/perf_tests.cpp (line 52)

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91351 --- Patch looks great! Reviews applied: [36378, 36380] All tests passe

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-10 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/ --- (Updated July 10, 2015, 8:52 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-09 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91263 --- src/tests/perf_tests.cpp (line 40)

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91246 --- Patch looks great! Reviews applied: [36378, 36380] All tests passe