Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Ben Mahler
> On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 108-110 > > > > > > Why not also add an Endpoint message to capture this part? Or a URL/I? > > > > message Endpoint

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Marco Massenzio
> On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 108-110 > > > > > > Why not also add an Endpoint message to capture this part? Or a URL/I? > > > > message Endpoint

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91537 --- Thanks for doing this! Please ping me when this gets committed (in c

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91520 --- include/mesos/mesos.proto (lines 108 - 110)

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91506 --- LGTM. Will wait for the test before giving shipit. - Vinod Kone O

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

2015-07-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91501 --- Patch looks great! Reviews applied: [36450] All tests passed. - M