Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93889 --- Ship it! Ship It! - Bernd Mathiske On Aug. 3, 2015, 1:43 a.m., J

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93886 --- Ship it! Ship It! - Joerg Schad On Aug. 3, 2015, 8:43 a.m., Jan

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93882 --- Patch looks great! Reviews applied: [36773] All tests passed. - M

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated Aug. 3, 2015, 10:43 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& > > Jan Schlicht wrote: > Path::basename() is not marked const (which it probably sh

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 6:34 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& > > Jan Schlicht wrote: > Path::basename() is not marked const (which it probably sh

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& Path::basename() is not marked const (which it probably should), hence we have to itera

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 3:59 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93447 --- src/tests/fetcher_cache_tests.cpp (line 1474)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93443 --- docs/fetcher-cache-internals.md (line 107)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 2:59 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93438 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 11:52 a.m., Ja

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 1:52 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93430 --- src/tests/fetcher_cache_tests.cpp (line 1460)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93300 --- Patch looks great! Reviews applied: [36773] All tests passed. - M

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 28, 2015, 1:42 p.m., Joerg Schad wrote: > > src/tests/fetcher_cache_tests.cpp, line 1450 > > > > > > Is this an expectation or assertion? IMO the test shouldn't continue if > > this fails. (I see that it

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 28, 2015, 4:04 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93287 --- Patch looks great! Reviews applied: [36773] All tests passed. - M

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 28, 2015, 1:42 p.m., Joerg Schad wrote: > > src/slave/containerizer/fetcher.cpp, line 987 > > > > > > Should we put a comment above the function saying that it is LRU based? Yes, we should! > On July 28,

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 28, 2015, 2:16 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 28, 2015, 11:42 a.m., Joerg Schad wrote: > > docs/fetcher-cache-internals.md, line 107 > > > > > > removes the *most* recently used first Sorry meant something along the lines: Cache eviction removes the c

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93272 --- docs/fetcher-cache-internals.md (line 107)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93132 --- Patch looks great! Reviews applied: [36773] All tests passed. - M

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 27, 2015, 5:38 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

> On July 24, 2015, 2:14 p.m., Joerg Schad wrote: > > src/slave/containerizer/fetcher.cpp, line 997 > > > > > > This new behavior should be reflected in the documentation. AFAIK there > > are two markdown files whic

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93116 --- Patch looks great! Reviews applied: [36773] All tests passed. - M

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 27, 2015, 2:52 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review92895 --- src/slave/containerizer/fetcher.cpp (line 994)