---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94196
---
Ship it!
Ship It!
- Marco Massenzio
On Aug. 5, 2015, 4:21 a.m.,
On Aug. 5, 2015, 6:05 a.m., Marco Massenzio wrote:
Ship It!
Tested on Mac OSX 10.10 (Python 2.7) and Ubuntu 14.04: by `export
PYTHONPATH=$MESOS_INSTALL_DIR/lib/python/site-packages` importing `mesos` and
associated modules works.
Thanks for fixing this, @haosdent!
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94213
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 4, 2015, 9:21 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94214
---
Ship it!
LGTM module the file ordering.
src/Makefile.am (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 9:54 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94215
---
src/python/interface/setup.py.in (line 27)
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 10:28 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 10:29 a.m.)
Review request for mesos, Bernd Mathiske,
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94243
---
Ship it!
I would say ship it if everyone agrees that this now
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote:
I would say ship it if everyone agrees that this now depends on this python
package just as a hack to add an empty __init__.py to the google submodule
for protobuf.
A better solution could be found later of course.
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote:
I would say ship it if everyone agrees that this now depends on this python
package just as a hack to add an empty __init__.py to the google submodule
for protobuf.
A better solution could be found later of course.
Sebastien Pahl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94249
---
Patch looks great!
Reviews applied: [37081]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 4:19 a.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 4:21 a.m.)
Review request for mesos, Kapil Arya and
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94191
---
did you forget to rebase?
- Marco Massenzio
On Aug. 5, 2015,
On Aug. 5, 2015, 5:47 a.m., Marco Massenzio wrote:
did you forget to rebase?
Never mind - I was just looking at diff 4 -- 5.
All good.
- Marco
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94165
---
Patch looks great!
Reviews applied: [37081]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 5:12 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 5:33 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 4:33 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94084
---
Can you please define how did you test that this works in the
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
30 matches
Mail list logo
