Re: Review Request 37188: Added std::hash template specializations.
On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 https://reviews.apache.org/r/37188/diff/6/?file=1037577#file1037577line677 I think this might be the right solution for the scope of the changes we're trying to make, but I don't think we'll want to keep this kind of tests. My preference would be to change `URL` to operate on `map` rather than `hashmap`. Jan Schlicht wrote: Agreed! Michael Park wrote: Could you file a JIRA ticket describing the issue and a few simple solutions for it? 1. Make `URL` operate on `map` rather than `hashmap` 2. Only update the `stringify` function to construct a temporary `map` from the `hashmap` in order to print them out in a deterministic order) 3. ... anything else you can think of Thanks! https://issues.apache.org/jira/browse/MESOS-3317 - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- On Aug. 25, 2015, 3:15 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 3rdparty/libprocess/src/tests/http_tests.cpp c22f9d35b5dc959ce9816d3358ebff92b853bf52 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
On Aug. 25, 2015, 12:36 p.m., Michael Park wrote: 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 https://reviews.apache.org/r/37188/diff/6/?file=1037577#file1037577line677 I think this might be the right solution for the scope of the changes we're trying to make, but I don't think we'll want to keep this kind of tests. My preference would be to change `URL` to operate on `map` rather than `hashmap`. Jan Schlicht wrote: Agreed! Could you file a JIRA ticket describing the issue and a few simple solutions for it? 1. Make `URL` operate on `map` rather than `hashmap` 2. Only update the `stringify` function to construct a temporary `map` from the `hashmap` in order to print them out in a deterministic order) 3. ... anything else you can think of Thanks! - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- On Aug. 25, 2015, 1:15 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 1:15 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 3rdparty/libprocess/src/tests/http_tests.cpp c22f9d35b5dc959ce9816d3358ebff92b853bf52 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Rebase master fix issue. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 3rdparty/libprocess/src/tests/http_tests.cpp c22f9d35b5dc959ce9816d3358ebff92b853bf52 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- 3rdparty/libprocess/include/process/pid.hpp (lines 154 - 155) https://reviews.apache.org/r/37188/#comment151643 Like elsewhere, can we move the body of this `hash_value` function into `hashprocess::UPID::operator()` and remove it? 3rdparty/libprocess/src/tests/http_tests.cpp (lines 677 - 695) https://reviews.apache.org/r/37188/#comment151645 I think this might be the right solution for the scope of the changes we're trying to make, but I don't think we'll want to keep this kind of tests. My preference would be to change `URL` to operate on `map` rather than `hashmap`. - Michael Park On Aug. 11, 2015, 9:57 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 11, 2015, 9:57 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 https://reviews.apache.org/r/37188/diff/6/?file=1037577#file1037577line677 I think this might be the right solution for the scope of the changes we're trying to make, but I don't think we'll want to keep this kind of tests. My preference would be to change `URL` to operate on `map` rather than `hashmap`. Agreed! - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- On Aug. 25, 2015, 3:15 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 3rdparty/libprocess/src/tests/http_tests.cpp c22f9d35b5dc959ce9816d3358ebff92b853bf52 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 11, 2015, 11:57 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Remove hash_value functions. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94858 --- 3rdparty/libprocess/include/process/address.hpp (line 160) https://reviews.apache.org/r/37188/#comment149513 `s/template/template /` - Michael Park On Aug. 10, 2015, 12:25 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 12:25 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 10:52 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Rebase master. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 2:25 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 11:45 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Summary (updated) - Added std::hash template specializations. Repository: mesos Description (updated) --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 12:28 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94517 --- Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (lines 677 - 687) https://reviews.apache.org/r/37188/#comment149141 Can you explain why these two comparisons in each case need to be done. - Alexander Rojas On Aug. 7, 2015, 11:45 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 11:45 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 1:53 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Add comment describing hashmap behaviour. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
