> On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > <https://reviews.apache.org/r/37188/diff/6/?file=1037577#file1037577line677> > > > > I think this might be the right solution for the scope of the changes > > we're trying to make, but I don't think we'll want to keep this kind of > > tests. > > > > My preference would be to change `URL` to operate on `map` rather than > > `hashmap`.
Agreed! - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 ----------------------------------------------------------- On Aug. 25, 2015, 3:15 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37188/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 3:15 p.m.) > > > Review request for mesos, Alexander Rojas and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > Added std::hash template specializations. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > df78f8e525c40b87e734e16979d3315f89e12594 > 3rdparty/libprocess/include/process/pid.hpp > 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 > 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 > 3rdparty/libprocess/src/tests/http_tests.cpp > c22f9d35b5dc959ce9816d3358ebff92b853bf52 > > Diff: https://reviews.apache.org/r/37188/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
