Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95208 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 4:21 p.m., Ji

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: > > This thing is rather complex and it deals with Mesos managed persisetent > > volumes and other system volumes in different but related ways; rootfs may > > or may not be used; and we'll provision image volumes later. I hope we > > iterate

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 579 > > > > > > What happens when persistent volumes are used without a new rootfs? > > Jie Yu wro

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 485 > > > > > > s/other/another/ 'other' sounds fine to me here. > On Aug. 12, 2015, 10:47 p.m.,

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/ --- (Updated Aug. 12, 2015, 11:21 p.m.) Review request for mesos, Lily Chen, Ian Do

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95154 --- This thing is rather complex and it deals with Mesos managed persise

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
> On Aug. 12, 2015, 1:43 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 399 > > > > > > Can we also log the container id and it's the linux filesystem > > isolator? It's m

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95046 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 399) <

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/ --- (Updated Aug. 11, 2015, 1:57 a.m.) Review request for mesos, Lily Chen, Ian Dow