Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/#review98522 --- 3rdparty/libprocess/src/latch.cpp (line 41)

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/ --- (Updated Sept. 10, 2015, 6:54 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-09 Thread Neil Conway
> On Sept. 9, 2015, 5:16 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, lines 757-773 > > > > > > Would you agree that what is happening here is not immediately obvious? > > > > N

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/#review98207 --- Ship it! 3rdparty/libprocess/include/process/metrics/counter.hpp (