Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Guangya Liu
> On 八月 31, 2015, 9:25 p.m., Michael Park wrote: > > @Guangya: I pointed out the undefined behavior as specified in the C++ > > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). > > Also, refer to > > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) which I

Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Michael Park
> On Aug. 31, 2015, 9:25 p.m., Michael Park wrote: > > @Guangya: I pointed out the undefined behavior as specified in the C++ > > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). > > Also, refer to > > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) which

Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Michael Park
> On Aug. 31, 2015, 9:25 p.m., Michael Park wrote: > > @Guangya: I pointed out the undefined behavior as specified in the C++ > > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). > > Also, refer to > > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) which

Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97149 --- @Guangya: I pointed out the undefined behavior as specified in the C

Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97088 --- 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp (line 8

Re: Review Request 37945: change const pass-by-value to const reference in stout

2015-08-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97071 --- Patch looks great! Reviews applied: [37945] All tests passed. - M