Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99204 --- Ship it! Ship It! - Guangya Liu On 九月 15, 2015, 10:24 p.m.,

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- (Updated Sept. 15, 2015, 10:24 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99114 --- Ship it! Ship It! - Anand Mazumdar On Sept. 15, 2015, 10:24

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99110 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2015, 9:32 p.m.,

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99109 --- Looks good, just a few more minor things. Also to save effort don't

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Anand Mazumdar
> On Sept. 15, 2015, 10:10 p.m., Anand Mazumdar wrote: > > include/mesos/executor/executor.proto, line 163 > > > > > > Minor: Can we also have a comment before the `framework_id` field ? > > > > //

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- (Updated Sept. 15, 2015, 8:13 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99102 --- include/mesos/executor/executor.proto (line 131)